Comments (10)
@vysakh-poulose, @VarunSriram99: We have a debounce on the onChange
method in neetoEditor. neetoEditor was facing significant performance-related issues due to multiple unnecessary re-renders on pressing each character. After multiple failed attempts on memoizations, we added a debounce of 100ms to prevent these re-renders. The Cypress team had added a small delay on the Cypress side to handle this case.
discussion _t
from neeto-editor.
@AbhayVAshokan there are genuine cases where this debounce can cause issues. Consider an example where a user is updating the data in multiple records from a reference file. They might be copy pasting the data.
Since the editor is most likely the last field in the form, they might have the tendency to use the shortcut key to submit the form. So they might do ⌘+v
and ⌘+enter
. This can happen under that 100ms debounce which causes the form to be submitted without the updated data. This can cause a bad user experience and confusion among the users due to the change in the data.
If there's no way out of the debounce then we should at least think of a mechanism which prevents the user from submitting the stale data.
from neeto-editor.
Understood. We will look more into the issue and let you know.
@gaagul _a spike _t
from neeto-editor.
@AbhayVAshokan Any updates on this?
cc @gaagul
from neeto-editor.
@vysakh-poulose I did explore a few strategies but was unsuccessful. The performance is taking a hit. I need some more time to check memory leaks and associated optimizations.
from neeto-editor.
@AbhayVAshokan Any updates on this?
cc @gaagul
from neeto-editor.
We couldn't take this up in the previous milestone. I shall take this up myself and share the updates here.
from neeto-editor.
@AbhayVAshokan Any updates on this?
from neeto-editor.
I'll fix this in M7.
from neeto-editor.
Fixed by #1066
https://abhay-ashokan.neetorecord.com/watch/d9f176fd-f1f5-44bf-b5d1-807487da0533
from neeto-editor.
Related Issues (20)
- Allow hiding the `Delete` option in the `Attachments` component
- Branding changes
- Extract PDF styles via CDN HOT 1
- Improvise the UI of the upload progress modal. HOT 3
- Fix the UI of the empty state of the inline attachment.
- Create a playground for neetoEditor in the storybook using the live examples plugin. HOT 1
- Editor table revamp
- Revamp the design of emoji picker HOT 1
- Revamp the Mentions component. HOT 1
- Revamp the Variables component.
- Convert neetoEditor to a controlled component HOT 3
- Add data-cy label to SecondaryMenuTarget component
- Unable to upgrade neeto-editor in Next.js app HOT 2
- Fix the link color inconsistencies
- Link color undefined in`editor-output-pdf.css`
- Icons for table menu. HOT 2
- Audit why the Image preview of EditorContent is not functional
- Add data-cy for font size option in editor
- [POC] Explore the possibility of not showing images/code block which are out of the view port.
- Reduce the toolbar icon weight for small editor instance
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neeto-editor.