Coder Social home page Coder Social logo

Comments (10)

AbhayVAshokan avatar AbhayVAshokan commented on July 30, 2024

@vysakh-poulose, @VarunSriram99: We have a debounce on the onChange method in neetoEditor. neetoEditor was facing significant performance-related issues due to multiple unnecessary re-renders on pressing each character. After multiple failed attempts on memoizations, we added a debounce of 100ms to prevent these re-renders. The Cypress team had added a small delay on the Cypress side to handle this case.

discussion _t

from neeto-editor.

VarunSriram99 avatar VarunSriram99 commented on July 30, 2024

@AbhayVAshokan there are genuine cases where this debounce can cause issues. Consider an example where a user is updating the data in multiple records from a reference file. They might be copy pasting the data.

Since the editor is most likely the last field in the form, they might have the tendency to use the shortcut key to submit the form. So they might do ⌘+v and ⌘+enter. This can happen under that 100ms debounce which causes the form to be submitted without the updated data. This can cause a bad user experience and confusion among the users due to the change in the data.

If there's no way out of the debounce then we should at least think of a mechanism which prevents the user from submitting the stale data.

from neeto-editor.

AbhayVAshokan avatar AbhayVAshokan commented on July 30, 2024

Understood. We will look more into the issue and let you know.

@gaagul _a spike _t

from neeto-editor.

vysakh-poulose avatar vysakh-poulose commented on July 30, 2024

@AbhayVAshokan Any updates on this?
cc @gaagul

from neeto-editor.

AbhayVAshokan avatar AbhayVAshokan commented on July 30, 2024

@vysakh-poulose I did explore a few strategies but was unsuccessful. The performance is taking a hit. I need some more time to check memory leaks and associated optimizations.

from neeto-editor.

vysakh-poulose avatar vysakh-poulose commented on July 30, 2024

@AbhayVAshokan Any updates on this?
cc @gaagul

from neeto-editor.

AbhayVAshokan avatar AbhayVAshokan commented on July 30, 2024

We couldn't take this up in the previous milestone. I shall take this up myself and share the updates here.

@AbhayVAshokan _a

from neeto-editor.

vysakh-poulose avatar vysakh-poulose commented on July 30, 2024

@AbhayVAshokan Any updates on this?

from neeto-editor.

AbhayVAshokan avatar AbhayVAshokan commented on July 30, 2024

I'll fix this in M7.

from neeto-editor.

AbhayVAshokan avatar AbhayVAshokan commented on July 30, 2024

Fixed by #1066

https://abhay-ashokan.neetorecord.com/watch/d9f176fd-f1f5-44bf-b5d1-807487da0533

from neeto-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.