Coder Social home page Coder Social logo

Comments (6)

huxuan avatar huxuan commented on August 21, 2024

@grissiom hi, wish you can view pull request #91 which seems to fix this bug.
If it's ok, just merge it with 'Fix #89' or something like that!

from buaathesis.

grissiom avatar grissiom commented on August 21, 2024

Github doesn't close this issue by analyze the merge commit. So just close it by hand.

from buaathesis.

huxuan avatar huxuan commented on August 21, 2024

Fixed by pull request #91

from buaathesis.

huxuan avatar huxuan commented on August 21, 2024

@grissiom hi, github do can close issue by commit with certain syntax.
When merge pull request you can add msg like 'Fix #89' to auto close this issue
More infomation can be found at https://github.com/blog/831-issues-2-0-the-next-generation
To be more specific, the "Commits + Issues" part.

from buaathesis.

grissiom avatar grissiom commented on August 21, 2024

@huxuan Yeah, thank you for that useful link. I wrote "fix issue #xx" and it seems that github failed to trigger the closing event.... I think "fix #xx" is ambiguous to the ones who is not familiar to github.

from buaathesis.

huxuan avatar huxuan commented on August 21, 2024

@grissiom As metioned in that post, only six synonyms is supported:

  • fixes #xxx
  • fixed #xxx
  • fix #xxx
  • closes #xxx
  • close #xxx
  • closed #xxx

so I think something like 'Issue Fixed #89' may be a better solution for your concern.
For me, I used to add "fix #XX" as a additional part of commit msg. Just like 394d729.

from buaathesis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.