Comments (3)
This should largely be a matter of updating the code in src/fs.rs
which does the serialization/deserialization and adding the appropriate derives in the few places where the rustc_serialize
derives are used.
It's likely that switching to Serde will change the serialized form of some of the files. That's not a big deal in itself, because the stored files are quite transient anyway. Currently though, we panic if we can't deserialize a file. The load function at least will have to be updated to return a result so that we can handle this case by proceeding as if the file doesn't exist.
from criterion.rs.
Just submitted a PR that attempts to switch over. All the tests pass, but I don't use this crate for any projects of my own so if there are known projects that could test that everything still works that would help out.
from criterion.rs.
Thanks!
from criterion.rs.
Related Issues (20)
- "cargo bench -- <filter>" does not actually filter the benchmarks
- Can't call a function for the benchmark from the crate inside a Rust workspace HOT 1
- Quickstart instructions still use criterion 0.4 HOT 1
- Benchmarking With One function result as Input
- Help needed? HOT 5
- Found argument '--bench' which wasn't expected
- Benchmarks not running when specifying benchmark name
- Skip setup for filtered out benchmarks
- Allow running benchmarks as tests under Miri
- Segfault in code that passes valgrind/asan HOT 1
- Save baseline does not work in 0.5 HOT 4
- Can clap be made optional? HOT 1
- Can I limit number of threads to use in benchmark? HOT 1
- Enable Github "Discussions"
- "How Should I Benchmark Small Functions?" section in book is nonsense HOT 1
- script / plugin to easily interpret benchmark with OpenAI / LLM
- Does criterion store the binary some for later investigations with valgrind or something else?
- Programmatically enable quick_mode
- Display Standard Deviation Estimate Along with Confidence Intervals in Terminal Output?
- Criterion is unable to generate line chart when BenchmarkId parameter is not number HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from criterion.rs.