Coder Social home page Coder Social logo

Comments (11)

bgrnwd avatar bgrnwd commented on May 19, 2024 2

Thanks for reporting this, I'll do some more investigation over the weekend. On first glance, it seems like this may be an API change.

from fotmob.

ItamarShDev avatar ItamarShDev commented on May 19, 2024 1

@bgrnwd maybe we should close it

from fotmob.

bgrnwd avatar bgrnwd commented on May 19, 2024

Confirmed it's an API change. I should be able to publish a version with the fix in the next couple days.

from fotmob.

bgrnwd avatar bgrnwd commented on May 19, 2024

@matthew2564 Give 1.0.4 a try and let me know if that fixes it

from fotmob.

matthew2564 avatar matthew2564 commented on May 19, 2024

@bgrnwd Bumped version to 1.0.4. Seem to have encountered s second issue.

Updated the example usage, and implemented the following code...
Screenshot 2022-09-22 at 07 49 13

This is the output when executing the above code
Screenshot 2022-09-22 at 07 50 22

The README.md suggests the methods should return a value, but upon running the code and looking at the type definitions, the methods return void.

Screenshot 2022-09-22 at 07 58 07

Any help is appreciated, thanks!

from fotmob.

bgrnwd avatar bgrnwd commented on May 19, 2024

@matthew2564 Hmm, the methods should return a value. Full disclosure, I'm not a JS/TS dev so I'm learning as I go. I'll see if I can figure out why. I did notice the type definition file is empty now too.

I've been meaning to switch to a logger instead of printing to the console so the URL, undefined and false will go away eventually.

from fotmob.

olamarvel avatar olamarvel commented on May 19, 2024

i think this is due to the compiler you used if yoou checked the compiled code in dist/fotmob.js u will see that each fucntion is being called in a self involking function with does not allow for returned values

from fotmob.

olamarvel avatar olamarvel commented on May 19, 2024

would send screenshot soon

from fotmob.

bgrnwd avatar bgrnwd commented on May 19, 2024

@olamarvel Thanks for the info and PR. I made the changes you suggested in #404

@matthew2564 Give 1.1.0 a try, I think I've got the example usage working this time

from fotmob.

bgrnwd avatar bgrnwd commented on May 19, 2024

@matthew2564 Want to give this a try again? There's been a couple new versions since July

from fotmob.

bgrnwd avatar bgrnwd commented on May 19, 2024

@matthew2564 Going to close this but happy to re-open it if you're still having the same issue with the newer versions.

from fotmob.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.