Comments (4)
Thank you first of all for checking it out. I appreciate it
I'm going to have a look at those functions and run more extensive tests as I didn't get these results earlier. I would also see how best to optimize them so they adhere to the parameters set as well as have a short run time.
from safetokengen.
@Urias-T I've added a checker. This should simulate the proper results every time an output is generated. I also added a minimum length exception for otp(2 - there are two criteria) and password(4 - there are four criteria), so an infinite loop is not triggered when the criteria set are not met.
from safetokengen.
Hey, @bgraphixx the password_gen_control
function was still failing its test intermittently. I figured it was as a result of the fact that the function itself uses string.punctuation
(which has about 32 possible output characters) to create the passwords whereas, the test file was testing with a limited string of about 20-something symbols.
This PR (#5) fixes that by also using string.punctuation
to test the function.
from safetokengen.
Hi @Urias-T, thank you for your contribution so far. I'll take a look at this PR
from safetokengen.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safetokengen.