Comments (20)
ok that needs fixed, in the interum any reason you are requiring knockout js seperately? probably best to have an application.js with
//= require knockout.min.js
//Require your app js
That by chance work at all?
from grails-asset-pipeline.
Looks like application/x-javascript
is an older obsolete equivalent to application/javascript
So thats very weird (thanks Safari) :) , Will fix
from grails-asset-pipeline.
that is how i am doing it. However in dev mode, the knockout.min.js is included as a separate <script>
tag and so has its own http request
from grails-asset-pipeline.
weird, i tested with chrome too, saw the same format application/x-javascript
... is it a Mac thing?
from grails-asset-pipeline.
yea surprisingly this one hasnt hit me yet... Thanks for opening the issue (Im on a Mac as well so kinda odd)
from grails-asset-pipeline.
Hmm I just attempted to test this. The mime type is determined by using the servletContext.getMimeType(). I just created a testmin.min.js and it was served properly using grails 2.2.1
from grails-asset-pipeline.
I assume you are running tomcat in dev correct? Also what jdk version are you running
from grails-asset-pipeline.
I am running Jetty 7.6.0, jdk version 1.7.0_45
from grails-asset-pipeline.
ah its Jetty then. fantastic.
from grails-asset-pipeline.
Pushed a release (1.3.0) which should resolve this issue. Asset File definitions can now be defined as multiple accepted content-types.
from grails-asset-pipeline.
Saw your comment on the commit, whoops! fixed in 1.3.1 wasnt meant to stay.
from grails-asset-pipeline.
👍 thanky
from grails-asset-pipeline.
sorry, i still have the same problem with knockout.min.js
since the format is "application/x-javascript", the uri
and extension
get changed at this line: https://github.com/bertramdev/asset-pipeline/blob/master/grails-app/controllers/asset/pipeline/AssetsController.groovy#L16
the uri
becomes "knockout" and the extension
becomes "min"
what is the purpose of that if statement? (line 15)
it seems like this code needs to happen before the if statement:
def contentTypes = AssetHelper.assetMimeTypeForURI(request.forwardURI)
format = contentTypes ? contentTypes[0] : null
from grails-asset-pipeline.
sorry to keep bugging on this issue...i do have a workaround using "-" :)
from grails-asset-pipeline.
Hah, guess its gonna be one of those days :). its because grails likes to mask off known extensions. i.e. js Hate to ask a silly question, any chance there is a newer jetty version?
from grails-asset-pipeline.
the extension is correct ("js") prior to the if statement
from grails-asset-pipeline.
don't worry about fixing this right away :) if I get a chance I'll write up a unit test for it
from grails-asset-pipeline.
I finally reproduced it by using Jetty, its definitely a Jetty in dev mode issue. I have a few helpers that have been added to AsseHelper since the original writing of this controller, let me clean it up a bit and this may be a non issue now.
from grails-asset-pipeline.
Ok, removed the debug println, and built a test app using Jetty and all your versions, finally reproduced the issue and confirmed a fix. Tests are passing for version 1.3.2
from grails-asset-pipeline.
looks good now thanks a bunch! 🍻
from grails-asset-pipeline.
Related Issues (20)
- External Dev Time Directory HOT 2
- Exception processing static resources from spring-security-ui HOT 5
- How to apply grails tag or GString in js files in assets path
- Doesn't handle invalid URLs.
- Release a v2.11.2 of the Grails 2 plugin
- No such property: file for class: asset.pipeline.grails.AssetPipelineFilter
- Asset compilation fails on require('moment') HOT 2
- Null handling issue in asset-pipeline 2.8.0 HOT 1
- Asset Pipeline doesn't handle a missing file or src attribute in a g.resource taglib call
- grails plugin asset-pipeline version 2.13.1 broken (No such property: responseBuilder for class: asset.pipeline.grails.AssetPipelineFilter) HOT 3
- less asset files are not compiled when packaging a binary grails 2 plugin
- assets-scoped dependencies are not resolved with pathingJar enabled HOT 1
- Caused by: org.codehaus.groovy.grails.web.taglib.exceptions.GrailsTagException: Error executing tag <asset:stylesheet>: java/util/Objects HOT 3
- Getting Cannot invoke method assetBaseUrl() on null object exception while running grails application with inline grails plugin HOT 1
- CVE-2015-5237 in protobuf HOT 2
- Grails Asset Pipeline Problem HOT 2
- How to Ignore PDF processing, gzip, etc but still include them ? HOT 1
- JavaScript files are not working in Grails 4.0.1 and assets-pipline 3.0.11 from other directories or custom directories.
- Possibility to add custom response headers HOT 1
- asset:javascript tag doesn't work in IntelliJ GSP pages
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grails-asset-pipeline.