Comments (5)
Bessel filters have no analytical solution and the code relies on finding the roots of the polynomials. org.apache.commons.math3.analysis.solvers.LaguerreSolver is used for this. As you know it's based on C++ code and converted to java. The C++ code had a buggy root finder and Bessel has been removed a while ago. Looks like the root finder of apache commons has an issue as well (or the Bessel function has been buggy but worked till recently as the roots were not affected). I guess the best plan of action is to remove Bessel completely and rather import the coefficients calculated by Scipy. That's also the way to do it for C++. I certainly have no time to get to the bottom of it as it's non-trivial and takes a lot of time.
from iirj.
Of course I'd be more than happy to accept pull requests which make sure the impulse responses match. Ideally also the unit tests should receive coefficients from python for comparison.
from iirj.
Thanks for cross checking though!
from iirj.
It seems that Scipy doesn't use a solver but instead has fixed results for the poles.
https://github.com/scipy/scipy/blob/f2ec91c4908f9d67b5445fbfacce7f47518b35d1/scipy/signal/filter_design.py#L2351
Perhaps this is also an approach for IIRJ?
I tried it with the given example of order 5. It looks slightly better, but there are still differences. I don't have time at the moment to investigate further. I'll try to take another look in two weeks.
from iirj.
I will prepare the PR after #27 is merged.
from iirj.
Related Issues (20)
- Version number mismatch? HOT 4
- Some help converting code from Matlab HOT 3
- Debug message HOT 2
- Bandpass filter frequency settings HOT 6
- Forward-Backward Filter HOT 4
- Real-time filtering vs array filtering HOT 2
- Question on Butterworth highPass, cutoff==Nyquist, coefficients are NaN? HOT 1
- Applying butterworth bandpass filter on a wav file HOT 1
- Input for butterworth filter on audio signal HOT 1
- Changing target Frequency while feeding in new Samples HOT 3
- Basic question on applying the filter HOT 2
- Python equivalent of a simple filter HOT 2
- A querstion about HighPass HOT 1
- A querstion about HighPass with value HOT 1
- [Question] I want to make a C# port of this, but... HOT 2
- Add Support for Cauer / Elliptic Filter HOT 1
- Issue with Odd-Order Highpass Filters HOT 2
- about sampling rate and cut off frequency HOT 1
- voice filter HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iirj.