Segfault on activating/deactivating kicking option about dawn

[PolynomialDivision]

You can also trigger this by

ubus dawn reload_config

I can confirm that the reconfiguration of other APs will lead to a crash.

[PolynomialDivision]

The issue is in the reset function

https://github.com/berlin-open-wireless-lab/DAWN/blob/master/src/utils/dawn_uci.c#L191-L199

[babarosaM33]

i ran dawn with gdb for one day, but could not get the crash. so i could not catch the bug.

[babarosaM33]

the routine to compile dawn with gdb

1. download openwrt sdk.

2. edit rules.mk at the root directory. enable -g3 option

3. disable config_sstrip and enable config no strip

4. build

[babarosaM33]

btw, my router only has 64MB memory, as a result, it could not run Valgrind to detect memory leak for memory limit. since openwrt's glibc does not have sanitize enabled, i could not check potential memory leak with automatic tools.

[XiaoliChan]

@PolynomialDivision Hello guy. I have a question, I want to kick device without check device bit rates, so what permanent should I set for bandwidth_threshold ?

[PolynomialDivision]

@PolynomialDivision Hello guy. I have a question, I want to kick device without check device bit rates, so what permanent should I set for bandwidth_threshold ?

I would say 0, but we use > for comparison, so we have to change the code.
https://github.com/berlin-open-wireless-lab/DAWN/blob/master/src/storage/datastorage.c#L601

[PolynomialDivision]

@XiaoliChan Please open a seperate issue for that. :)

I will close this issue since it is fixed with: 1da5ad5

[PolynomialDivision]

@XiaoliChan Sry, 0 is wrong! Set it to a very high value. Maybe we introduce new magic numbers.

[XiaoliChan]

@XiaoliChan Sry, 0 is wrong! Set it to a very high value. Maybe we introduce new magic numbers.

Well, what is the max value?

[PolynomialDivision]

Well, what is the max value?

Should be INT_MAX so 2147483647.

[XiaoliChan]

Should be INT_MAX so 2147483647.

Thanks, I set it to this value now.