Coder Social home page Coder Social logo

Comments (5)

yubozhao avatar yubozhao commented on May 19, 2024

@SuperCD Thanks for point it out!

We need to update the kubernetes example that works correctly with the Gunicorn deployment. We will hopefully get that fixed very soon.

Is this issue something very urgent with you? If it is, we will try our best to get it done sooner.

Feel free to ping me on this or any other questions!

from bentoml.

SuperCD avatar SuperCD commented on May 19, 2024

thanks for the fast reply. I've tested it and in fact i was able to make it run if the binding is done on 0.0.0.0
I'm not even sure that changing the binding is the only way of solving this, but is the only one I've found...

from bentoml.

yubozhao avatar yubozhao commented on May 19, 2024

Thanks for investigating @SuperCD!

I think you found the issue. Which is right now, the docker container right now is only listening localhost.

We will address this issue and also improve the experience for deploying with Docker. Those changes should solve the problem you are encountering now.

Just some idea in my head right now, I am thinking about using Nginx/gunicorn setup inside the docker container.

I will link the PR to this issue, hopefully I can get to it sometime close to next week or so. Feel free to ping me, if you need it before that. I will pump it up and work on it sooner

from bentoml.

yubozhao avatar yubozhao commented on May 19, 2024

hi @SuperCD, I did a little bit more digging on this topic and We think your solution right now is the best one moving forward.

We did think about having an Nginx in the docker container as well. However, we realized that right now, most deployment solution probably already have an Nginx component that sits in front of the apps already (kubernetes' ingress controller for example). The Nginx won't bring too much value inside the container.

I think it is more fitting that you submit the PR to fix this problem since you provide the solution as well. What do you think? Otherwise, I will merge in the PR 138 that I linked above

from bentoml.

yubozhao avatar yubozhao commented on May 19, 2024

closing this issue now, since we merged in PR138. Feel free to open again, if there is additional issue relate to this.

from bentoml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.