Menu control doesn't pick up live color theme change about adonis-ui

[benruehl]

I looked at your repository and found the issue.

In your App.xaml you have the following:

<ResourceDictionary.MergedDictionaries>
    <ResourceDictionary Source="pack://application:,,,/AdonisUI;component/ColorSchemes/Light.xaml" />
    <ResourceDictionary Source="pack://application:,,,/AdonisUI;component/ColorSchemes/Dark.xaml" />
    <ResourceDictionary Source="pack://application:,,,/AdonisUI.ClassicTheme;component/Resources.xaml" />
    <ResourceDictionary Source="/DataTemplates/ContentTemplates.xaml" />
</ResourceDictionary.MergedDictionaries>

Change this to:

<ResourceDictionary.MergedDictionaries>
    <ResourceDictionary Source="pack://application:,,,/AdonisUI.ClassicTheme;component/Resources.xaml" />
    <ResourceDictionary Source="/DataTemplates/ContentTemplates.xaml" />
</ResourceDictionary.MergedDictionaries>

... and you're done.

Explanation

The way the color schemes work is that they both define colors and brushes with identical x:Key values. Each style e.g. for the menu items references the colors using those keys. When you switch the color scheme, the colors of the old scheme are removed and the colors of the new scheme are added instead. You should always include only one color scheme file. If you include both, the latter overwrites the former.

In your app this is not visible at first because you call ChangeTheme() on startup which calls ResourceLocator.SetColorScheme(). If you look at this method you can see that it searches for the first occurence of one of those color scheme files in you App.Resources in order to replace it with the other one. But because you included both files at the same time one remains in the resources and overrides the other.

[maximilien-noal]

Ah, I get it. That fixed it !
Thank you for your great explanation. :)