AttributeError: type object 'Solver' has no attribute 'requirements' about benchopt

[Badr-MOUFAD]

Should it be closed after the merge of #562?

[mathurinm]

Hi @UR4NVS, thanks for your feedback !
If the solver is not installed, you indeed need to tell benchopt which packages needs to be installed in order for the solver to work, by adding a requirements attribute as you did.

However I am surprised that you got a bug, because if the solver is not installed it should be skipped. Can you share the command that generated the error? And if your benchmark is public, can you share a link to the repo?

[albanPi]

Here is my repo and it wasn't a command written by myself, this occurred during a Github test for my PR. You can find here the error message and the details.

[tomMoral]

I think the issue is with the benchopt install command, when collecting uninstalled solvers. If there is an import error in the safe_import_context, it expect to find a requirements attribute. If there is none, I would suggest we raise a more comprehensive error :)

@UR4NVS , do you think you could look into this? this involves changing the line here
to check if the requirements exists and raise an error asking to add a requirements attribute in the solver class if not.

[mathurinm]

fixed by #562