Comments (19)
Should be fixed by #560, could you please verify?
from bem-bl.
@indutny проверил с веткой из PR - в собранном bemhtml.js ничего не поменялось кажется и проблема остается. Если что - код для проверки тут, в bower.json просто можешь свою ветку ставить и смотреть :)
from bem-bl.
Это потому что ты используешь bem-bl-xjst, в нем есть своя копия bem-bl. Сейчас сделаю и туда PR.
from bem-bl.
from bem-bl.
@indutny - попробовал с bem-bl-xjst из ветки что в PR, тоже ничего не полетело, возможно еще что-нибудь надо поменять? (enb-xjst версию?)
from bem-bl.
Все ясно, у тебя теперь там другой пример :) Вопрос же был про чтение из this
, а теперь ты туда пишешь и даже вызываешь apply. cc @veged
from bem-bl.
@indutny да, эту проблему тоже обсуждали и казалось что оно связанно
from bem-bl.
там вроде только apply и вызывается? что мешает также сделать как и с чтением из this? если есть apply то прокидывать честный объект
from bem-bl.
@veged я придумал как сделать, скоро починим :)
from bem-bl.
@indutny ping :)
from bem-bl.
@indutny pong
from bem-bl.
@indutny Am I right that the fix should also be ported to bem-xjst
?
from bem-bl.
I'd wait for a whole fix. Right now I have fixed only part of it in these commits and in veged/xjst@e4cffd6 . Going to finish this up tomorrow.
from bem-bl.
@belyanskii please give a try to latest: bem-archive/bem-bl-xjst#5
from bem-bl.
@indutny it's working!! brilliant!! @tadatuta, now i need new versions of library's 👍
from bem-bl.
@indutny Fedor, will you release bem-bl-xjst yourself or should I do it while you're on vacation? :)
To do so I just need to know how destructive these changes are: should it be major version or patch will be enough? And should it be ported into support/1.x branch as well?
And what about bem-xjst
? Do we need any changes there or weak deps on xjst
is just enough?
from bem-bl.
@tadatuta I'll do it in a patch version, and yeah it should be ported.
from bem-bl.
@belyanskii released in [email protected]
from bem-bl.
@tadatuta ah, it seems like support/1.x is not affected, because it isn't using this optimisation.
from bem-bl.
Related Issues (20)
- Up `enb-xjst` to `1.2.0`
- Use `enb-bem-docs` & `enb-bem-examples`
- Updated `enb` dependencies
- Не отменяется инициализация уничтоженных блоков HOT 2
- i-bem__dom: afterCurrentEvent should guarantee block existence HOT 1
- i-bem__html.bemhtml: Use the same object for `this.mods` and `this.ctx.mods`
- i-ua.js, window.matchMedia returns null in hidden iframes HOT 2
- Extract I18N from bem-bl HOT 1
- i-bem: Method getMods always returns empty hash HOT 2
- Feedback for "i-bem.js: Руководство пользователя" HOT 3
- b-slider: слайдер при инициализации затирает наследуемую от i-bem__dom функцию HOT 2
- i-bem: trigger twice runs jquery-trigger HOT 3
- b-page: Dependency from i-jquery__core should be optional HOT 1
- Добавьте jscs с принятым у вас стайлгайдом(если он есть) HOT 5
- $.observable.un with handlers hash and ctx not working HOT 1
- i-fastclick: Exposes a lot of globals
- Небольшая защита для удаленных блоков HOT 4
- Нет возможности делегировать события mouseenter и mouseleave HOT 2
- Return key string from BEM.i18n if no translation found
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bem-bl.