Coder Social home page Coder Social logo

Comments (11)

beltoforion avatar beltoforion commented on July 21, 2024

Should be -1 but it not really dangerous since strind::npos is defined to be -1. No truncation taking place.

from muparser.

VioletGiraffe avatar VioletGiraffe commented on July 21, 2024

I see what you mean, agreed. But MSVC does complain about truncation; the warning itself should be enough reason to fix this piece of code, IMO, regardless of how justified the warning is.

from muparser.

jschueller avatar jschueller commented on July 21, 2024

@beltoforion could you register the project on appveyor to enable msvc builds so we can actually see what's going on ? (https://www.appveyor.com/)

The appveyor configuration was added in #38 but not actually used. If you want I can set it up for you if you grant me the rights to the repository.

from muparser.

giraldeau avatar giraldeau commented on July 21, 2024

I registered the project in my account, but there is no automatic trigger.

https://ci.appveyor.com/project/giraldeau/muparser

from muparser.

beltoforion avatar beltoforion commented on July 21, 2024

Sorry, I have no idea what appveyyor is or does. Never used it before.
@jschueller i have added you as a collaborator so if you want to set it up feel free to do it.

from muparser.

jschueller avatar jschueller commented on July 21, 2024

Great, I could enable Appveyor, see the new README.rst.
It seems I need admin rights on the repo too to enable Travis though.

from muparser.

jschueller avatar jschueller commented on July 21, 2024

@VioletGiraffe what of msvc version did you use ? any special flags ?

from muparser.

VioletGiraffe avatar VioletGiraffe commented on July 21, 2024

@jschueller: msvc 2017 (v141 toolset), /W4 flag.

from muparser.

beltoforion avatar beltoforion commented on July 21, 2024

@jschueller: giving admin rights does not seem to be so easy. Seems i need to create a new organization and transfer project ownership. (Something i would do if everything else fails)

I connected muparser to travis-ci can you access it there?

from muparser.

jschueller avatar jschueller commented on July 21, 2024

Travis works properly, thanks.
Now I realize AppVeyor was only enabled on my fork and does not trigger builds from here. Could you do the same for AppVeyor ?

from muparser.

beltoforion avatar beltoforion commented on July 21, 2024

I added it to appveyor. Please check out if you see it.

from muparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.