Comments (7)
Indeed, I had noted the problem. I am planning to show an overlay box with the
current
search, that way the user will know the context he/she is (so the backspace can
recover
its original action safely).
I am not sure about the timeout, though. I know FF behaves that way, but
backspace has
no associated action. Now let's imagine we have a search, the timeout is
reached just
before we backspace it... we end with an unwanted 'back' action. Not an usual
situation,
granted, but still possible. Open a new issue if you see how to overcome this
detail,
though.
Thanks for your suggestions.
Original comment by tokland
on 16 Dec 2009 at 10:16
- Changed state: Accepted
from chrome-type-ahead.
I thought FF will also go back in history when you press backspace??
A good point about canceling at the 'wrong time'. I'm not sure how FF handles
that, I
no longer have FF installed to check ;)
An easy way would be to lock down backspace after you start type-ahead finding,
and
release it if the user presses "esc". Also, not to lock down backspace if the
user
hasn't done any typing on the page yet-- which is the issue now.
FF does have a lot of checks on the backspace key, and have a protection for if
you hit
backspace too many times while removing characters from your search string.
Maybe you
could use that same protection, and also add an extra timeout protection that
ignores
backspace for 1 second after the timeout or something.
Here is the code from FF (linked to the backspace function):
http://mxr.mozilla.org/firefox2/source/extensions/typeaheadfind/src/nsTypeAheadF
ind.cpp
#735
Original comment by [email protected]
on 16 Dec 2009 at 10:55
from chrome-type-ahead.
0.0.3 shows box with current search.
When no box, backspace goes back.
Original comment by tokland
on 18 Dec 2009 at 7:12
- Changed state: Started
from chrome-type-ahead.
The box doesn't disappear for me unless I click a link. Even when the box is
empty it
is still there breaking backspace history navigation. It would be nice if the
box
disappeared and was emptied when you click on the page just like Firefox FAYT
works.
Original comment by [email protected]
on 19 Dec 2009 at 1:51
from chrome-type-ahead.
The box disappears when you press Esc. But yes, it should also disappear when
you click
in the page, I'll do it.
Original comment by tokland
on 19 Dec 2009 at 10:27
from chrome-type-ahead.
done: r17
Original comment by tokland
on 19 Dec 2009 at 12:06
from chrome-type-ahead.
Original comment by tokland
on 19 Dec 2009 at 10:39
- Changed state: Fixed
from chrome-type-ahead.
Related Issues (20)
- Change highlight color HOT 3
- Option for . instead of / (like Opera) HOT 2
- Allow option to only start searching with "/" HOT 1
- Doesn't search inside file:/// directory listings HOT 2
- custom shortcut HOT 1
- tab/ctrl+tab to move to next link/previous link HOT 2
- Allow positioning of the search box HOT 2
- 0.4.1 starts search when in form field HOT 15
- Change text of 'direct search state' to make it clear what this is and what it means HOT 2
- Blacklisting doesn't work HOT 8
- Please reduce access rights to my browsing behavior HOT 2
- Search doesn't trigger when at a file:// URL HOT 1
- 'R' key does not work in type ahead search HOT 1
- interface HOT 1
- no option to change popup text color or apply general styles
- Copying entered HOT 1
- no longer working in latest chrome canary 41.0.2232.0 HOT 2
- Page's shortcut keys are triggered while searching HOT 2
- in Opera: possible to deactivate some keys? HOT 1
- Search ahead is active when it shouldn't be on workflowy.com
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chrome-type-ahead.