Coder Social home page Coder Social logo

Comments (4)

codewithtyler avatar codewithtyler commented on August 22, 2024

There's already a JSHint ready to use in the Gruntfile.js. Are you wanting it to run automatically via CI or do you mean something else with this issue?

from beagle-term.

sunglim avatar sunglim commented on August 22, 2024

Are you wanting it to run automatically via CI or do you mean something else with this issue?

via CI.

I'm going to create something like /tools/run-all-js-test.py that runs jshint for all directories. and run it via CI.
Thank you for your comment. Feel free to share any idea.

PS. grunt is good when we write code. but when we review a code we need to see the jshint result.

from beagle-term.

codewithtyler avatar codewithtyler commented on August 22, 2024

In some of the open source project's I've worked on in the past we've just made the CI run the grunt task. By doing it that way any jshint errors will show up as a failed check on the PR. The PR can't be merged until it passes the check. It's pretty much the same concept as your CLA bot.

You can also integrate jscsrc with jshint to enforce the Google Style Guide.

from beagle-term.

sunglim avatar sunglim commented on August 22, 2024

Thank for the info, It sounds like we can run grunt task on CI. I updated issue description.

from beagle-term.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.