Comments (4)
There's already a JSHint ready to use in the Gruntfile.js
. Are you wanting it to run automatically via CI or do you mean something else with this issue?
from beagle-term.
Are you wanting it to run automatically via CI or do you mean something else with this issue?
via CI.
I'm going to create something like /tools/run-all-js-test.py that runs jshint for all directories. and run it via CI.
Thank you for your comment. Feel free to share any idea.
PS. grunt is good when we write code. but when we review a code we need to see the jshint result.
from beagle-term.
In some of the open source project's I've worked on in the past we've just made the CI run the grunt task. By doing it that way any jshint errors will show up as a failed check on the PR. The PR can't be merged until it passes the check. It's pretty much the same concept as your CLA bot.
You can also integrate jscsrc with jshint to enforce the Google Style Guide.
from beagle-term.
Thank for the info, It sounds like we can run grunt task on CI. I updated issue description.
from beagle-term.
Related Issues (20)
- extension validation fail when loading HOT 1
- BeagleTerm 1.7 is released! HOT 5
- Support for telnet and SSH connections HOT 3
- Unable to talk to a device on Chrome OS HOT 36
- New version (maybe) hangs on connect HOT 5
- Local Echo HOT 5
- Higher baudrate support HOT 1
- v1.8.0 beta release HOT 2
- locks up when attempting to connect 9600 HOT 3
- Locks up when opening a connection HOT 27
- Communication outside of GitHub HOT 2
- Remove bower dependency. HOT 2
- Improve comments to use JSDoc HOT 1
- Feature Request - Send a file to the serial port.
- Line break causes terminal to suspend silently HOT 2
- Multiple serial port behaviour HOT 4
- Support for copy and paste? HOT 3
- Line Feed instead of Carriage Return+Line Feed
- Weird Display of Unicode Degree Symbol
- How to you set the backspace to ctrl-h?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beagle-term.