Comments (5)
@oyeanuj thanks, glad to hear you're thinking about using universal-redux!
first, as for bringing changes into react-redux-universal-hot-example, i'm hoping that the collaborators on that repo see the value, and i have a series of PR's open:
- to bring in universal-redux 0.x (babel5, redux-router): erikras/react-redux-universal-hot-example#626
- to bring in universal-redux 1.x (babel5, redux-simple-router): erikras/react-redux-universal-hot-example#685
- to bring in universal-redux 2.x (babel6, redux-simple-router): erikras/react-redux-universal-hot-example#730
there's a lot of change there, and @quicksnap has mentioned that he's going to explore it in a test project first. here's his comments on it: erikras/react-redux-universal-hot-example#685 (comment)
as for migrating your own app, it may or may not be complicated, depending on how much you've modified some parts of the original repo.
places that i can think of that need would need some consideration:
- ApiClient.js. This would have to be added as a Redux middleware since it's not a part of universal-redux. You can see how I did this with a slightly modified version of ApiClient (which I call 'fetcher) in the JWT example project here: https://github.com/bdefore/universal-redux/tree/master/examples/jwt/src/redux/middleware. I don't think it should be difficult for you.
- The api server: This is also not a part of universal-redux, but should run fine independently, as long as you add the related proxy to the Express instance. My universal-redux start_es6.js does this in the PR: https://github.com/bdefore/react-redux-universal-hot-example/blob/babel6/bin/start_es6.js
other than that, everything in your src/containers
directory should stay where they are. you'll just need to create a config
directory with a universal-redux.config.js as mentioned in the README.
you may find it easier to start with the branch of my PR (erikras/react-redux-universal-hot-example#730) and then drop your app into it. this assumes you'd want to update to babel 6 and redux-simple-router.
i'd definitely like to hear if you plan to do this, and would be happy to help.
from universal-redux.
If you do try to migrate your app, I'm very interested in your experience as well. As mentioned, I'm going to try and test this out on another greenfield project, however it's been taking me a while to get to it.
I haven't heard a ton of feedback from anyone using it, but I would really love to hear how it's gone for others.
from universal-redux.
@bdefore @quicksnap I took another look at it, and I think it does make it easier to understand a lot of the data-fetching logic and the setup.
I would like to give it a shot, maybe once my project stabilizes a little bit. Hopefully, someone else can do it sooner and provide feedback. @bdefore, once it merges, would you expect people to send PRs to this library or just to the RRUHE and you would merge things back to this library?
As an aside, @bdefore, your comment above would be a really useful migration guide for that PR :)
from universal-redux.
@oyeanuj i don't know that this will be merged to RRUHE, but whether or not it is a migration guide would definitely help. i'll elaborate further on the comment above and put it into a markdown doc in the repo.
from universal-redux.
Let's continue this on #26
from universal-redux.
Related Issues (20)
- onEnter can't redirect HOT 1
- How to access external server api (rails or laravel ... etc) from universal-redux?
- [webpack-isomorphic-tools] (waiting for the first Webpack build to finish)
- how the server side API requests handle the jwt token?
- Move to redux-connect HOT 1
- Help required?
- Question about waiting for Server Requests HOT 1
- Question about โAdd routes, reducer and rootClientComponent aliases so that client has access to themโ HOT 5
- Setting scroll behavior for the router
- SVG Loading Configuration
- Different CSS idents cause server render to be discarded HOT 1
- Using npm dependencies listed in Universal-redux on the project level HOT 3
- [webpack-isomorphic-tools] asset not found HOT 9
- Question: how to alter the JS loader HOT 4
- Passing Express request headers to Html component?
- @@router/UPDATE_LOCATION fired after first dispatched action HOT 3
- Server-side React render was discarded HOT 5
- Use redux-devtools-extension HOT 1
- integrate HappyPack
- should user other way to compile es6-7 with babel
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from universal-redux.