Coder Social home page Coder Social logo

Comments (5)

bdefore avatar bdefore commented on July 28, 2024

@oyeanuj thanks, glad to hear you're thinking about using universal-redux!

first, as for bringing changes into react-redux-universal-hot-example, i'm hoping that the collaborators on that repo see the value, and i have a series of PR's open:

there's a lot of change there, and @quicksnap has mentioned that he's going to explore it in a test project first. here's his comments on it: erikras/react-redux-universal-hot-example#685 (comment)

as for migrating your own app, it may or may not be complicated, depending on how much you've modified some parts of the original repo.

places that i can think of that need would need some consideration:

other than that, everything in your src/containers directory should stay where they are. you'll just need to create a config directory with a universal-redux.config.js as mentioned in the README.

you may find it easier to start with the branch of my PR (erikras/react-redux-universal-hot-example#730) and then drop your app into it. this assumes you'd want to update to babel 6 and redux-simple-router.

i'd definitely like to hear if you plan to do this, and would be happy to help.

from universal-redux.

quicksnap avatar quicksnap commented on July 28, 2024

If you do try to migrate your app, I'm very interested in your experience as well. As mentioned, I'm going to try and test this out on another greenfield project, however it's been taking me a while to get to it.

I haven't heard a ton of feedback from anyone using it, but I would really love to hear how it's gone for others.

from universal-redux.

oyeanuj avatar oyeanuj commented on July 28, 2024

@bdefore @quicksnap I took another look at it, and I think it does make it easier to understand a lot of the data-fetching logic and the setup.

I would like to give it a shot, maybe once my project stabilizes a little bit. Hopefully, someone else can do it sooner and provide feedback. @bdefore, once it merges, would you expect people to send PRs to this library or just to the RRUHE and you would merge things back to this library?

As an aside, @bdefore, your comment above would be a really useful migration guide for that PR :)

from universal-redux.

bdefore avatar bdefore commented on July 28, 2024

@oyeanuj i don't know that this will be merged to RRUHE, but whether or not it is a migration guide would definitely help. i'll elaborate further on the comment above and put it into a markdown doc in the repo.

from universal-redux.

bdefore avatar bdefore commented on July 28, 2024

Let's continue this on #26

from universal-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.