Comments (6)
Hi @kolpanic. I actually encountered this issue on Sunday while attempting to work through issue #35, but didn't have time to resolve it. From what I read in the release notes, it appears it was a conscious decision by the maintainers of AFNetworking to change the way percent encoding works to abide by a certain RFC:
This release migrates query parameter serialization to model AlamoFire and adhere to RFC standards. Note that / and ? are no longer encoded by default.
Unfortunately, this means it comes down to me to restore the previous encoding in this library. I'll do my best to make that happen later this evening. You're more than welcome to submit a PR if you beat me to it! 😃
from bdboauth1manager.
@bdbergeron From my reading of the RFC, it's more of a suggestion than a requirement. However, they've chosen to follow it, so, thanks.
from bdboauth1manager.
@bdbergeron If you can think of a better approach, feel free to ignore my PR.
from bdboauth1manager.
@bdbergeron I just tried this fix with AFNetworking 2.5.4, and (predictably) it doesn't work. I'm not aware of a way to check the AFNetworking version at runtime, so you may have to require 2.6 going forward.
from bdboauth1manager.
I definitely plan on the next release (1.6.0) bumping the requirement for AFNetworking to 2.6.+. I've been sticking to the versioning convention of BDBOAuth1Manager 1.x.+ utilizing AFNetworking 2.x.+ as much as possible, just so that it's as clear to developers that AFNetworking changes might result in changes to this library.
from bdboauth1manager.
So it looks like @skj4sc solved this issue in a PR to a different fork of this project (toopher#2), so I just cherry-picked his fixes into here. Should be good to go with AFNetworking 2.6.+ as of commit f4288a8.
from bdboauth1manager.
Related Issues (20)
- Signature only HOT 8
- Prefix categories with bdb_ to help prevent possible conflicts HOT 1
- Subtle bug in fetchRequestToken HOT 6
- Always get could not acquire OAuth request token HOT 1
- How to get user's info in twitter? HOT 1
- Documentation HOT 1
- Yelp provides token HOT 1
- Workspace files for working on the project HOT 2
- How can i use this with 2 legged oauth authentication? HOT 2
- Cocoapods and use_frameworks! HOT 5
- Unauthorized when upload file HOT 3
- Broken Build HOT 7
- Podspec update? HOT 3
- Provide hook to use AFJSONRequestSerializer HOT 1
- Once i close the app,access token to remain saved HOT 1
- Include of non-modular header inside framework module HOT 1
- Carthage and shared frameworks! HOT 2
- Where is BDBOAuth1RequestOperationManager? HOT 1
- Swift Package Manager support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bdboauth1manager.