Comments (5)
I did bdbch/cordlr-cli#112.
I'll go to bed now, maybe I can make a PR tomorrow or you are faster.
from cordlr-palettes.
I made an PR and I reported this bug to coolors.co. They said, they gonna fix this too.
from cordlr-palettes.
The fix is really simple, just need to change this:
message.reply('Here is your palette: https://coolors.co/' + colorString)
to this:
message.reply('Here is your palette: https://coolors.co/' + colorString, {
embed: {
image: {
url: 'https://coolors.co/export/png/' + colorString
}
}
})
The only problem here is, that the used discord.js version in cordlr not really supports embed messages (not as reply and the method message.channel.sendEmbed doesnt exist, also you can't send an embed message with message.channel.sendMessage as second argument).
I updated discord.js inside cordlr for testing purpose to the latest discord.js version (11.0.0 right now) and this fix worked fine, but with the current used discord.js version, I'm pretty sure you cant send an embed message.
We really need to upgrade discord.js.
from cordlr-palettes.
I'll update Discord.js. Could you add an issue for that on the cordlr-cli repository? I'll take care of that. You can also send in a PR if you want to.
Otherwise great one! I'll implement embeds into other modules too.
from cordlr-palettes.
Discord.js is updated!
from cordlr-palettes.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordlr-palettes.