Coder Social home page Coder Social logo

Adding new icons about v4 HOT 11 CLOSED

bchiang7 avatar bchiang7 commented on May 14, 2024
Adding new icons

from v4.

Comments (11)

bchiang7 avatar bchiang7 commented on May 14, 2024

Hey @abhishek-t-naive, It's hard for me to help you without seeing any code! My only suggestion is to double-check your spelling?

from v4.

abhishektyaagi avatar abhishektyaagi commented on May 14, 2024

Aah! I should have shared my repo with you.

https://github.com/abhishek-t-naive/v4

Here I have posted the most recent version of what I have been working on. The structure is the same as your website.

Moreover, I would like to know from you if there is a specific format in which .js files should be. I am a novice when it comes to JS, so I am not aware. As I don't use a Mac, I can't use Sketch to generate a logo. I tried using Inkscape to generate an SVG file which I converted to a .JS file using this but that didn't work just like with the youtube-icon.

Is it possible for you to point out any particulars while trying to add new icons, logos or other .js files?

from v4.

bchiang7 avatar bchiang7 commented on May 14, 2024

Just took a quick look and it looks like there's nothing wrong with the youtube icon. Is there any more context you can provide?

from v4.

abhishektyaagi avatar abhishektyaagi commented on May 14, 2024

I am not sure if I have anything else to add to this.
I am using:
.nvm/versions/node/v12.16.2/ on Ubuntu 18.04

Is it possible for you to try out the Youtube icon integration on your end to see if it a system-specific issue?

from v4.

bchiang7 avatar bchiang7 commented on May 14, 2024

Hey @abhishek-t-naive I cloned your repo and added youtube as a social media item in config.js -- it seemed to show up fine?

image

Note that I had to comment out the cover graphql query first in order to get the site to run

from v4.

abhishektyaagi avatar abhishektyaagi commented on May 14, 2024

The above is working fine for me as well in config.js. But if you have a look at the file index.md, I am trying to display the icon along with the github and external website icon (beside github in the image below for featured projects)

Selection_002

My apologies, I don't think I presented you with the actual file with the problem before

from v4.

bchiang7 avatar bchiang7 commented on May 14, 2024

Gotcha, you'd have to add youtube to the GraphQL query and pull it into the Featured component

from v4.

abhishektyaagi avatar abhishektyaagi commented on May 14, 2024

Yeah, this worked perfectly. With the above changes, I also modified other section of Featured component. Thank you!

Before we close the issue, I would just like to ask you that to replace the logo at the start, do I just need to make replace the loader.js with that of the new logo or are there more places to make changes to?
[You can ignore this if it is something that I am supposed to figure out myself, considering that you did not design the website as a template]

from v4.

bchiang7 avatar bchiang7 commented on May 14, 2024

You'd also have to change IconLogo in the nav. Glad you figured it out!

from v4.

abhishektyaagi avatar abhishektyaagi commented on May 14, 2024

Hey @abhishek-t-naive I cloned your repo and added youtube as a social media item in config.js -- it seemed to show up fine?

image

Note that I had to comment out the cover graphql query first in order to get the site to run

Hey @bchiang7 , why did you have to comment out the 'cover' graphql query in order to get the site to run?

from v4.

bchiang7 avatar bchiang7 commented on May 14, 2024

it was throwing an error for me

from v4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.