Comments (3)
Anyway, I've just fixed "the issue" in my code generation pipeline with dirty string replacement: export interface Params {}
-> export type Params = Record<string,never>
Maybe we just should add some option to the converter? Something like exposeEmptySchemaObjectWithNoAdditionalPropertiesAllowedAs
?
from json-schema-to-typescript.
We have a test case covering this. But for the life of me I don't remember where in the spec I saw that this is the correct behavior.
Reading it now, the JSON-Schema Spec is a bit ambiguous: a schema that omits properties
is equivalent to TypeScript's any
(in that, every value is valid), but it's unclear whether properties: {}
is also equivalent to any
, or if it should be strictly interpreted as "nothing matches".
Would love a second pair of eyes, if you can help sleuth through the various versions of the JSON-Schema Spec to dig up the correct behavior.
from json-schema-to-typescript.
I suppose that a schema that omits properties is equivalent to TypeScript's any
only if additionalProperties
in schema resolved to true
. Of course this is a very rare case. Here is the case: I have ajv
validator in my json-rpc server pipeline. And it fails to validate request with any properties in args against the schema in my first message. But ts interface
produced from this schema allows any properties. It's a bit inconsistent...
UPD: Also this should be consistent with another prop: unevaluatedProperties
from json-schema-to-typescript.
Related Issues (20)
- Crash for deprecated field missing description HOT 1
- A bit unclear about the purpose of `declareExternallyReferenced` and intention HOT 1
- Support ESM usage of module HOT 3
- Create `index.ts` when generating files from a directory HOT 1
- List on json-schema.org HOT 1
- Create Typscript schema with external references
- Remove optional flag in case of `default` in schema. HOT 8
- `strictIndexSignatures` option is ignored for single pattern properties
- Package lists dev dependencies as dependencies HOT 4
- If `minProperties` is greater than or equal to the number of declared properties and `additionalProperties` is `false`, all properties should be required HOT 2
- properties + anyOf generates incorrect output
- `compile()` ignores `$refOptions.resolve` settings HOT 1
- What package manager does the repo use? HOT 6
- `SyntaxError` while building browser bundle HOT 2
- Add option to remove `[k: string]: unknown | undefined;` from generated types HOT 5
- Add yaml support HOT 3
- Static imports for $refs HOT 4
- bug in vercel production, but development environment is OK HOT 1
- "SyntaxError: Unexpected token in JSON at position 0" when running CLI on MacOS HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-schema-to-typescript.