Fakers used inside Rules of other Fakers share the same object reference about bogus

[MihaiDaniel]

@bchavez Indeed that was the issue, thanks for the quick response!

[bchavez]

The problem is the declaration .RuleFor for the following inner class as a constant:

.RuleFor(mc => mc.MyInnerClass, new MyInnerClassFaker().Get());

The correct way to invoke the lambda upon each generaiton is to use the lambda overload; not the value/constant overload:

.RuleFor(mc => mc.MyInnerClass, f => new MyInnerClassFaker().Get());
                               ^^^^^^

You need to make sure if you want something done on each generation instance, that you use lambdas .RuleFor( ... , f => f); not .RuleFor( ... , valueConstant).

And a working example:

void Main()
{
   MyClassFaker myClassFaker = new();
   MyClass class1 = myClassFaker.Get();
   MyClass class2 = myClassFaker.Get();
   class1.MyInnerClass.Id.Dump();
   class2.MyInnerClass.Id.Dump();
}

public class MyClass
{
   public int Id { get; set; }

   public MyInnerClass MyInnerClass { get; set; }
}

public class MyInnerClass
{
   public int Id { get; set; }
}

public class MyClassFaker
{
   private Bogus.Faker<MyClass> faker = new();

   public MyClassFaker()
   {
      faker
         .RuleFor(mc => mc.Id,           f => f.Random.Int())
         .RuleFor(mc => mc.MyInnerClass, f => new MyInnerClassFaker().Get()); // Your bug was here.
   }

   public MyClass Get() { return faker.Generate(); }
}

public class MyInnerClassFaker
{
   private Bogus.Faker<MyInnerClass> faker = new();

   public MyInnerClassFaker()
   {
      faker.RuleFor(mc => mc.Id, f => f.Random.Int());
   }

   public MyInnerClass Get() { return faker.Generate(); }
}

OUTPUT

1449290238
130403538

Hope that helps.