Coder Social home page Coder Social logo

Comments (4)

jakubmatisak avatar jakubmatisak commented on July 2, 2024 1

I was debbuging it for last 4 hours. Finally I have found the problem.
Problem is not with the VueFlow, but it was happening from 1.33.5+.

Solution was kinda stupid, but it was caused by wrapping node and passing in into its child slot.
After removing one <div> it works fine. The fun part is that we didn't changed a thing, except the library version, so I was expecting a bug in vueFlow.

I'm also adding a code:
This is EndNode template

<template>
  <node-dialog-wrapper v-bind="props">
    <tooltip-wrapper
      :error="getErrors()"
      :text="getErrors()"
    >
      <v-card
        color="background"
        elevation="3"
      >
        <v-card-text>
          <v-icon
            class="icon ma-1"
            color="primary"
            size="35"
          >
            mdi-circle
          </v-icon>


          {{ label }}
        </v-card-text>
      </v-card>

      <handle
        :position="Position.Top"
        type="target"
      />
    </tooltip-wrapper>
  </node-dialog-wrapper>
</template>

and this is TooltipWrapper:

<template>
  <div v-if="text?.length > 0">
    <slot />
    <v-tooltip
      activator="parent"
      :class="{'error': error}"
      :close-delay
      :location
      :open-delay
    >
      <template v-if="Array.isArray(text)">
        <div
          v-for="(value, index) in text"
          :key="index"
        >
          {{ $t(value) }}
        </div>
      </template>
      <span v-else>{{ $t(text) }}</span>
    </v-tooltip>
  </div>
  <div v-else>
    <slot />
  </div>
</template>

Bug is caused by <div v-if="text?.length > 0"> in Tooltip wrapper.
After removing everything except <slot> its working fine.

I'm sorry that I was wasting yourr time, but you have to admit it is weird.
Thank you for your time.

from vue-flow.

bcakmakoglu avatar bcakmakoglu commented on July 2, 2024

Can you provide a proper reproduction for this issue?

from vue-flow.

bcakmakoglu avatar bcakmakoglu commented on July 2, 2024

Tbh I can't reproduce any bugs here.
Maybe it's a misconception with markerEnd and markerStart and where the start and end is.

If you're not defining all <Handle> as type="source" and using ConnectionMode.Loose the handles will be used according to their type (source + target), where the source handle will always be the start and the target handle always be the end, so the markerEnd would always point to the target handle and not the source.

Other than that (which isn't a bug but intended) I can't see any "problems".

from vue-flow.

bcakmakoglu avatar bcakmakoglu commented on July 2, 2024

Interesting, I'll still give it a look, maybe there is something there 😄

from vue-flow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.