pngPath is not defined about electron-icns-ex

[slavikator]

Thanks for the explanation. This is my first Electron project, definitely something wrong with my understanding here. ))

[BB-fat]

pngPath is the destination path where the converted icns file is stored, which is defined by yourself.

[slavikator]

That's what I understood. So, it seems nothing wrong with the code and still, I get an error.

[BB-fat]

try replace parseIcnsToPNG(localIconPath, pngPath); to icns.parseIcnsToPNG(localIconPath, pngPath);

[slavikator]

Yes, I have done this before - the same error.

[BB-fat]

Can you show me more complete code and error? And did you try icns.parseIcnsToBase64?

[slavikator]

This is basically what is related to showing the image.

renderer.js

    const localIconPath = ddPath + "/Contents/Resources/" + CFBundleName + ".icns";
    const icns = require('electron-icns-ex');
    icns.parseIcnsToPNG(localIconPath, pngPath);
    const img = document.querySelector("#localIcon");
    img.src = pngPath;

index.html

          <div>
            <img id="localIcon" src="">
          </div>

log

P.S.
The image displays if I replace the img.src = pngPath to img.src = "pathtoimage.png", where pathtoimage.png is a test image saved locally.

[slavikator]

Didn't figure out how to use the icns.parseIcnsToBase64

[BB-fat]

There are two problems here.

1. This module is a native module, and you can not use native module in the renderer process. You should write these code in main process and pass the result to renderer process via IPC channel.
2. There is something wrong with your understanding here, maybe it's because my README is relatively simple and doesn't make it clear. The corrected code is as follows.

// in main process
const localIconPath = ddPath + "/Contents/Resources/" + CFBundleName + ".icns";
const icns = require('electron-icns-ex');
const pngPath = '/tmp/test.png'; // To save the png file, you need to specify the path manually.
icns.parseIcnsToPNG(localIconPath, pngPath);

// in renderer process
const img = document.querySelector("#localIcon");
img.src = pngPath;

[BB-fat]

I'll close this issue, if there is still a problem you can reopen it.

[slavikator]

const pngPath = '/tmp/test.png'; // To save the png file, you need to specify the path manually.
I need to avoid saving the file.
It seems the icns.parseIcnsToBase64 must be used instead.

Will this be correct then?

// in main process

const localIconPath = ddPath + "/Contents/Resources/" + CFBundleName + ".icns";
const icns = require('electron-icns-ex');
const base64 = icns.parseIcnsToBase64(localIconPath);

// in renderer process

const img = document.querySelector("#localIcon");
img.src = base64;

[BB-fat]

That's right.