bazzline / php_component_curl Goto Github PK
View Code? Open in Web Editor NEWfree as in freedom simple object oriented curl request and response component (YACC - yet another curl component)
License: GNU Lesser General Public License v3.0
free as in freedom simple object oriented curl request and response component (YACC - yet another curl component)
License: GNU Lesser General Public License v3.0
Hi Stev,
I've just found that there is an issue with sending post requests with json as content type using this component.
The first problem is the fact that default header
'application/x-www-form-urlencoded; charset=UTF-8'
is always set in
https://github.com/bazzline/php_component_curl/blob/master/source/Request/RequestFactory.php#L80
so even if you use asJson() method in builder it will have two different content type headers.
'application/json'
'application/x-www-form-urlencoded; charset=UTF-8'
And because the default one is the last one then it is overriding json content type.
Lastly if request is of json type then ConvertJsonToArrayBehaviour
is called after performing the request.
But there at line https://github.com/bazzline/php_component_curl/blob/master/source/ResponseBehaviour/ConvertJsonToArrayBehaviour.php#L24
json_encode function is triggered instead of json_decode.
As a workaround user can call Builder::reset(true)
method after builder create
method to just have this headers empty and then use asJson to make the valid content type.
But there is no way to fetch the correct response content since original json content is encoded once again after fetchin instead of json_decode
ing.
Regards
Luke
There is an PHP-Doc issue in the method Builder::withTheRawOption.
While PHP-Doc only allows to pass strings as values, it should be of type mixed.
E.g. when you are passing CURLOPT_HTTPHEADER which as an array as value option.
psr-7 is out.
Does it make sense to write a dedicated Builder dealing with psr 7 request and returning a psr 7 response?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.