File paths with spaces aren't handled by params files about rules_swift

[allevato]

#61 by itself will break us internally. There are a couple places I know of where I "cheat" to pass space-separated string arguments on a single line, and that change will quote them incorrectly.

However, that cheat should be unnecessary now because of some other improvements to the Args APIs, so I'll make the necessary changes internally tomorrow and run it against our CI.

[keith]

Actually it looks like clang doesn't support this either, so I assume this was intentional on the Swift side and we should fix it here

[allevato]

I commented on the Swift bug you linked. The standalone example is working as expected, because there aren't quotes around the filename.

For Swift builds specifically, if you can grab one of the params files that Bazel creates and show that a path with a space in it isn't being quoted, that would be good to know. If that's the case, it's not a rules_swift bug, but a Bazel bug. We just use the Args API to add files to the argument list, and it's up to that object to quote/escape things correctly (if spaces in filenames are even meant to be supported; I tend to avoid them because they always cause problems).

[keith]

For Swift builds specifically, if you can grab one of the params files that Bazel creates and show that a path with a space in it isn't being quoted, that would be good to know.

Yes this is the case now.

if spaces in filenames are even meant to be supported; I tend to avoid them because they always cause problems

I agree but it still seems like something we should fix here.

But it sounds like I should move this issue to bazel?

[allevato]

But it sounds like I should move this issue to bazel?

Yes, please do. If the intent is for params files generated by Args to support spaces in paths, then it will need to be fixed there.

[keith]

Filed here bazelbuild/bazel#6224

[kastiglione]

@allevato why compile_args.set_param_file_format("multiline")? The default param file format ("shell") would solve this problem, would it break other things?

[keith]

Changing this from multiline to shell does seem to fix it for us. I'm not sure what other implications that has though. The files end up quoted in this case.

[keith]

Based on the documentation here https://docs.bazel.build/versions/master/skylark/lib/Args.html#set_param_file_format it seems like that might be the intention. I've submitted a PR here assuming that this is a fix we should do here #61