Coder Social home page Coder Social logo

Comments (8)

allevato avatar allevato commented on August 20, 2024 1

It looks like I don't have the necessary privileges on bazelbuild/bazel to use the GitHub transfer there. ☹️

from rules_swift.

allevato avatar allevato commented on August 20, 2024 1

Search CROSSTOOL.tpl for "-version-min"—you'll see that the other platforms appear to pass it consistently, but macOS is left out entirely.

from rules_swift.

keith avatar keith commented on August 20, 2024 1

I've submitted bazelbuild/bazel#6891 to try and fix this

from rules_swift.

allevato avatar allevato commented on August 20, 2024

This looks like a CROSSTOOL issue. The flags passed to the cc_library compilation aren't affected by whether they're a dependency of a swift_binary or not.

But if I look at Bazel's CROSSTOOL.tpl, I don't see -mmacosx-version-min= passed anywhere by the Darwin toolchain. The other platforms like iOS do pass it, so it looks like this was an omission there. Can you file an issue with bazelbuild/bazel?

swift_binary does respect the target triple in both compilation and linking, so once the CROSSTOOL issue is resolved, everything should work as expected.

from rules_swift.

keith avatar keith commented on August 20, 2024

Do you have the ability to migrate this issue to bazel now to maintain this context?

from rules_swift.

keith avatar keith commented on August 20, 2024

Where are you seeing that the other platforms do pass it?

from rules_swift.

keith avatar keith commented on August 20, 2024

Ah sorry I understand it now

from rules_swift.

keith avatar keith commented on August 20, 2024

Confirmed it does fix this case

from rules_swift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.