I found a bug in "get" and "set" prefix for object about ecmascript-sublime

[bathos]

Thank pucelle. I thought this was something that got fixed a while back, and when I test it I’m getting the right behavior:

However it might be borked only in specific contexts. Can you provide a complete chunk which reproduces the problem?

[pucelle]

Hi, Bathos.
Sorry for reply you late.
Here is code that cant work with my sublime:

Watcher.prototype = {
	get () {
		let oldDeps = this.deps
		let newDeps = this.deps = Object.create(null)

		runningWatcher = this
		let value = this.getter.call(this.vm[proxySymbol])
		runningWatcher = null

		for (let key in oldDeps) {
			let oldObserver = oldDeps[key]
			if (!newDeps[key]) {
				oldObserver.removeWatcher(key, this)
			}
		}

		return value
	},
	set (value) {
		let {vm, exp, writeVM, setter} = this

		if (!writeVM) {
			let firstProp = lexer.getFirstProperty(exp)
			writeVM = this.writeVM = this.findWriteVM(vm, firstProp)
		}

		if (!setter) {
			setter = this.setter = lexer.compileWritter(exp)
		}
		
		setter.call(vm, writeVM[proxySymbol], value)
	},
}

[pucelle]

Here is the screenshot:

[bathos]

That appears to be a different syntax definition for JS, not ES sublime. The scoping throughout that screenshot is not consistent with this library.

(Some of the clues: vm is not a specially scoped identifier in ES Sublime; properties being assigned are not scoped different from properties not being assigned in ES Sublime unless the RHS is a function; inconsistent highlighting of let, etc.)

If you can confirm this is using ES Sublime and things are just really wonky, feel free to re-open.

[pucelle]

Hi, Bathos:
After checked my syntax config in Sublime, I did choose the "JavaScript" as syntax, not 'EcmaScript'.
Sorry for the trouble I made.