Coder Social home page Coder Social logo

Comments (3)

saemideluxe avatar saemideluxe commented on May 12, 2024

Regarding the loading indicator: Would it be acceptable to take it inside the input field? It would make parts of the implementation more clear because the loading indicator is technically more related to the search input than the content of the returned answer.

from basxconnect.

saemideluxe avatar saemideluxe commented on May 12, 2024

Okay, this is ready for review. Two things which differ from the screenshots are:

  1. The loading indicator
  2. The width of the result box is the same as the table and not the same as the input box. This is related to how carbon design structures the toolbar and the datatable. They are two separate containers and the toolbar does not allow having visible overflow containers which makes alignment via CSS basically impossible. There is no way to get the correct width of the search input except using javascript and setting the width after the page has been loaded and running the script. So, there would be a way to implement the feature but I wonder how important it is. If it is really too unpleasent for the eye I can spend a bit more time trying to find a better way to get things aligned correctly.

from basxconnect.

frederikbugglin avatar frederikbugglin commented on May 12, 2024

Regarding the loading indicator: Would it be acceptable to take it inside the input field? It would make parts of the implementation more clear because the loading indicator is technically more related to the search input than the content of the returned answer.

yes, this is acceptable — and even better.

from basxconnect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.