Comments (3)
Regarding the loading indicator: Would it be acceptable to take it inside the input field? It would make parts of the implementation more clear because the loading indicator is technically more related to the search input than the content of the returned answer.
from basxconnect.
Okay, this is ready for review. Two things which differ from the screenshots are:
- The loading indicator
- The width of the result box is the same as the table and not the same as the input box. This is related to how carbon design structures the toolbar and the datatable. They are two separate containers and the toolbar does not allow having visible overflow containers which makes alignment via CSS basically impossible. There is no way to get the correct width of the search input except using javascript and setting the width after the page has been loaded and running the script. So, there would be a way to implement the feature but I wonder how important it is. If it is really too unpleasent for the eye I can spend a bit more time trying to find a better way to get things aligned correctly.
from basxconnect.
Regarding the loading indicator: Would it be acceptable to take it inside the input field? It would make parts of the implementation more clear because the loading indicator is technically more related to the search input than the content of the returned answer.
yes, this is acceptable — and even better.
from basxconnect.
Related Issues (20)
- Mailchimp sync: Handle cleaned addresses HOT 2
- Create household based on a natural person on the fly
- [BUG] Multiline addresses not displayed as expected HOT 6
- [Task] No permission to add tags as non admin HOT 2
- [BUG] Add/Edit subscription broken HOT 5
- [feature] - Tooltip help
- [BUG] - Indent in culumn header HOT 1
- [feature] - show mailchimp status in e-mail block
- [BUG] no way of creating a person with a subtype HOT 1
- improve useability of "add relationship" form HOT 1
- Fix some translations HOT 3
- Person's ReadView shows an empty page when the last opened tab was removed. HOT 1
- Select columns to be displayed in Person overview HOT 1
- [BUG] Missing translation in edit e-mail popup HOT 3
- Improve tooling for adding relationships HOT 1
- Improve object-URL generation
- Improve UI for vocabularies
- Vocabulary UI HOT 1
- Improve editing of email, web and phone
- Move gender to person detail main tab
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from basxconnect.