Coder Social home page Coder Social logo

Comments (4)

BartSte avatar BartSte commented on May 25, 2024 1

@rasmusq thanks for your interest in this plugin.

As stated in the readme, wouldn't the expected behaviour be:

After jumping to a mark, jump to the last cursor position in that file. That's it, nothing more.

So no jump is made to the file mark, instead the cursor jumps to the last position in the file.

Does this help?

from nvim-project-marks.

BartSte avatar BartSte commented on May 25, 2024 1

I think ik you set mappings = false in your config, you will gat the behaviour you want, i.e., the vanilla vim behaviour while you marks are still stored in the local shada file.

from nvim-project-marks.

rasmusq avatar rasmusq commented on May 25, 2024 1

Well, I just can't seem to understand any of the features of this plugin. Of course that is the setting that does that!
Thank you for your patience.
I don't think the time I spent yesterday was for nothing, as I got introduced to how Neovim plugins work.

Closing the issue...

from nvim-project-marks.

rasmusq avatar rasmusq commented on May 25, 2024

Hi @BartSte.
First of all, thank you for making this plugin!
It is truly a necessary feature making the mark functionality actually useful in NeoVim. I don't know if the marks feature would be usable for me if it didn't exist.
I would argue that its flexibility and proximity to the native implementation makes it a better tool than Harpoon.

That does help with my understanding.
I must have read the point wrong initially.

After reading more into it, I now understand my confusion.
When going to a global mark A, it runs the motion 'A'".
The " mark updates every time the buffer is exited as expected.
What I didn't expect is that it also updates when deleting a mark.
That has got to be a quirk of NeoVim or something.

So it is probably working as expected, sorry for the ping!

I might see if I can change the plugin to only do what you write in your first point:

  • "Set marks that only a apply to a specific project".

So jumping to global marks happens as it does in vanilla NeoVim.

Thank you again for a great plugin and for the quick response. I hope it gains some traction.

Edit 1

Seems like it is a very easy change in the code, so I will just post it here if others stumble upon this. You just have to comment these three lines in projectmarks.lua:

---@param symbol string
local function _jump_with(symbol)
  local mark = vim.fn.nr2char(vim.fn.getchar())
  local command = symbol .. mark

  -- if mark == string.upper(mark) then
  --   command = command .. symbol .. '"'
  -- end
  vim.api.nvim_feedkeys(command, "n", false)
end

An option to disable this jumping, of course, is not in the initial goals of the project, so I do not expect it to be an official change, however...

Edit 2

I have made a local branch for myself with an option to disable the jumping to ".
If you want to have a look at my (very small) commit or use it in the repo, I can publish it as a feature suggestion.

from nvim-project-marks.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.