Coder Social home page Coder Social logo

Comments (11)

erikn69 avatar erikn69 commented on June 13, 2024 1

Fixed on #615

from laravel-debugbar.

devajmeireles avatar devajmeireles commented on June 13, 2024

It looks like the error is here:

CleanShot 2024-03-11 at 11 21 21

from laravel-debugbar.

barryvdh avatar barryvdh commented on June 13, 2024

@erikn69 because of maximebf/php-debugbar#606 ?

from laravel-debugbar.

barryvdh avatar barryvdh commented on June 13, 2024

Hmm not really familiar with SPA mode, but probably because the parent is resolving to itself?

from laravel-debugbar.

barryvdh avatar barryvdh commented on June 13, 2024

Or maybe we can just check if the parent debugbar is not the same object as the current debugbar, to prevent a loop?

What is the easiest to replicate this? It seems turbolinks is deprecated for 2 years?

from laravel-debugbar.

erikn69 avatar erikn69 commented on June 13, 2024

Maybe, maximebf/php-debugbar#613 (comment)

window.parent && window.parent != window.top && window.parent.phpdebugbar && window.parent.phpdebugbar != this

I have no way to test it, @devajmeireles could you test it??

from laravel-debugbar.

devajmeireles avatar devajmeireles commented on June 13, 2024

@erikn69 @barryvdh ,

I was able to confirm that the new version was able to fix the issue. I'll mark this as resolved. Thanks!

from laravel-debugbar.

erikn69 avatar erikn69 commented on June 13, 2024

the new version was able to fix the issue

new version not was a fix, was a regression, maximebf/php-debugbar#613 (comment) was a possible fix, but I was hoping you could corroborate it because I can't replicate your environment

from laravel-debugbar.

devajmeireles avatar devajmeireles commented on June 13, 2024

the new version was able to fix the issue

new version not was a fix, was a regression, maximebf/php-debugbar#613 (comment) was a possible fix, but I was hoping you could corroborate it because I can't replicate your environment

What do you prefer? A demo repo or better instructions to test that piece of code?

from laravel-debugbar.

erikn69 avatar erikn69 commented on June 13, 2024

Nevermind, i did reproduce the problem

from laravel-debugbar.

devajmeireles avatar devajmeireles commented on June 13, 2024

Awesome! Anyway, here is the demo repo: https://github.com/devajmeireles/bug-debugbar

  1. Clone and setup the repo
  2. Prepare the .env. using SQLite
  3. Run the migrations
  4. Create an account
  5. Open the browser console
  6. Navigate between the links at the top of the page

I needed to create the repo using the v1.20.0 of maximebf/php-debugbar

from laravel-debugbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.