preventCheck when trying to browser to a PDF (or other file types?) about barba

[luruke]

Hey @jonnyscholes !
I could add a regex/file extension on the href url, but I don't thing is a good idea.
My doubt is that an URL that ends with .pdf that doesn't necessary means that the file is a pdf.

What is your idea?

(By the way In the next version I'll also make sure to support the download attribute)

[jonnyscholes]

Supporting the download attribute would be awesome! (I would be happy to submit a PR for this btw). But it doesnt help many users who are stuck with things like TinyMCE which dont (easily) allow adding of attributes/classes to inserted anchor links. For example default Wordpress websites dont allow any changes of anchor HTML at all.

Technically someone could have a link that ends in .pdf (or other file extensions) that returns a valid HTML page - but I would have thought they would be the exception, and not the rule. Most urls that end in .pdf are a pdf download seeing is a very widely recognized format - along with others like doc and docx.

From my point of view it would be more reasonable for people that are returning html from a .pdf endpoint to override the preventCheck method than those that are not - as it is a pretty odd thing to do.

We could implement it in a way that is configurable so users can override the formats by doing something like:

Barba.Pjax.start({ignoreFiles: ['pdf', 'doc', 'exe', 'dmg']})

(or similar)

[luruke]

Thanks @jonnyscholes .
I'll think about it.

Maybe another solution could be to check the HTTP Content-Type header.

Thanks for the issue!

[luruke]

Added support for download attribute in the new version.
965a266

[jonnyscholes]

I think between the download attribute and the docs including how one would do this (which it does here) this issue can be closed. I'm more than satisfied as a user :)