possible bug with python wrapper (shell=True) about bandup

[paulovcmedeiros]

Hi Chris!

Many thanks for your interest in BandUP and for reporting this issue. I've been able to reproduce it by running the code in an environment without git. I suspect this is the case in your system.

If subprocess tries to call a command that is not available, then an OSError exception is raised. Since all systems I use have git, I ended up overlooking this. I have now fixed the error by catching the exception. I prefer, however, not to use shell=True (see, for instance, https://docs.python.org/3.4/library/subprocess.html#security-considerations). This is avoided by catching the OSError exception.

Just FYI: The reason why shell=True works is because, by doing so, no exception is thrown. Instead, a "command not found" system error msg gets sent to the "stderr" variable and then "get_latest_git_tag" simply returns None. As discussed above, however, I prefer to avoid using shell=True if possible.

Many thanks once more for taking your time to report this issue. I appreciate and encourage this.

Best wishes,
Paulo.