Coder Social home page Coder Social logo

Comments (6)

robamler avatar robamler commented on June 19, 2024

Yeah, no need to explain yourself for using old versions of python packages, I know painfully well how disastrous the package management situation is in python :). There's no deep reason for requiring numpy ^1.19.0, it's just the oldest version of numpy I've ever tested with.

I just released a new version of constriction (v0.3.3) that reduces the required numpy version to ^1.16. Please let me know if this resolves your problem (you'll need to use python 3.10 or older; for python 3.11, we require numpy ^1.23.2, and for python 3.12 we require numpy ^1.26.1; relaxing those requirements would be much more difficult).

from constriction.

kshpytsya avatar kshpytsya commented on June 19, 2024

Perfect timing. I was about to do a fork. However, there is a problem, probably due to a possible maturin's bug, which causes wheels to contain Requires-Dist: numpy~=1.19 in METADATA regardless of the target python version. A quick scan of maturin's issue tracker didn't discover anything relevant. So I suppose, someone should open an issue. I believe you to be more suitable as my acquaintance with maturin is cursory. If you do not have time for that, I will try opening an issue myself.

P.S. Maybe I am barking at the wrong tree, but I cannot add constriction to my Poetry project requiring Python 3.8 which has other dependencies requiring numpy<1.19.

from constriction.

kshpytsya avatar kshpytsya commented on June 19, 2024

P.P.S. It looks like you should change requirements here:

"numpy~=1.19",

See https://www.maturin.rs/metadata.
I have verified that those are the requirements that make it into the wheel metadata, and you have changed only Poetry-specific requirements.

from constriction.

robamler avatar robamler commented on June 19, 2024

Sorry, I should have double checked this. Thank you for hunting down the bug yourself!

I fixed it in commit 3f2a96c and just released a new version (this time I did actually look into the wheel's metadata and verified it now contains "numpy~=1.16". Please let me know if this works for you.

from constriction.

kshpytsya avatar kshpytsya commented on June 19, 2024

Great! I can confirm that constriction==0.3.4 is installable by Poetry==1.7.1 into Python==3.8.16 along with numpy==1.18.5. I have also verified that encoder works.

I minor detail – I am unsure whether it is worth a separate issue – is the following warning from Poetry:

Warning: Validation of the RECORD file of constriction-0.3.4-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl failed. Please report to the maintainers of that package so they can fix their build process. Details:
In /home/uken/.cache/pypoetry/artifacts/bf/7f/3e/dafe24f40a54f14858cdb770e83c4fc076d2a8e86141bb380a25393718/constriction-0.3.4-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl, LICENSE.html is not mentioned in RECORD

from constriction.

robamler avatar robamler commented on June 19, 2024

Great, thanks! I opened #43 for the issue about validating python wheels. The warning is no reason for concern, but I should indeed fix it to prevent the warning message.

from constriction.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.