Coder Social home page Coder Social logo

Comments (3)

hostep avatar hostep commented on June 19, 2024 1

Hi @Morgy93

Indeed, I can reproduce this problem on a clean Magento 2.4.2 installation!

I've only tested this module on Magento 2.4.0 so far, not on 2.4.1 or 2.4.2, so something in those versions has changed which must have caused this problem.

I'll have a look later on for a way to solve this.

Thanks!

from magento2-module-url-data-integrity-checker.

hostep avatar hostep commented on June 19, 2024 1

Is fixed in version 1.2.1 of this module.

I picked option 4 and introduced a silly workaround for the issue. The other options would be better for future improvements, but would take a lot longer to implement.

Also, we aren't the only ones who run into this problem with Magento 2.4.2, see: magento/magento2#32292

Thanks for the report @Morgy93!

from magento2-module-url-data-integrity-checker.

hostep avatar hostep commented on June 19, 2024

Magento 2.4.2 came with this change which starts causing this issue: magento/magento2@2638e0f

This feels like a bug in Magento because a Collection isn't being forced to implement a getSelect() method.

And since we use the Collection to read from a json file and not from the database this might be difficult to implement.

Possible solutions:

  • start storing and reading data to/from the database instead of from a json file (which we were already planning of doing in scope of #13 (comment))
  • use an alternative Magento grid implementation like https://github.com/hyva-themes/magento2-hyva-admin (downsides: it currently only supports Magento 2.4 or higher and PHP 7.4 or higher)
  • the combination of the two above
  • doing something clever that is much less work then the above (not sure if that will be possible)

This might take a while until fixed since I don't have that much free time, but I'll see what I can do 🙂

from magento2-module-url-data-integrity-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.