Coder Social home page Coder Social logo

Comments (9)

baldurk avatar baldurk commented on June 26, 2024

I'm not quite clear on this, is this a feature request or a bug report? It seems like a feature request for VK_NV_linear_color_attachment and your description doesn't seem to detail any kind of bug but you've used the bug report template. I'm going to file this as a feature request for now but please let me know if I've misunderstood.

from renderdoc.

alecazam avatar alecazam commented on June 26, 2024

Yes, that’s fine. I wasn’t sure if it was a bug that this extension wasn’t appearing, or that RenderDoc is filtering the extension due to a missing feature.

from renderdoc.

alecazam avatar alecazam commented on June 26, 2024

Also would be nice to know when an extension is suppressed by enabling RenderDoc_capture. Wasn't expecting that to alter the extensions so drastically. And it's always present on Win/Android, but the dll isn't. So we can disable the extension only when RenderDoc is running the app on most of our platforms.

from renderdoc.

baldurk avatar baldurk commented on June 26, 2024

I don't really understand what you mean by "it's always present". There's no need for a separate query for RenderDoc though, supported extensions are reported through the normal vulkan enumeration functions and an application can react to the available extensions without needing to special-case anything for RenderDoc, the same way as it does for different drivers.

from renderdoc.

alecazam avatar alecazam commented on June 26, 2024

The issue is that the capture extension is always present for RenderDoc. Maybe because I have RenderDoc installed. But I’ve had to add tests for platforms that we know have a particular extension, since when we activate the capture extension many of the unsupported Nv extensions disappear from the list.

Right now I search for the DLL and if present then I activate the capture extension, but only. I’m using this to identify that the app was launched from RenderDoc.

from renderdoc.

baldurk avatar baldurk commented on June 26, 2024

I don't know what you mean by a capture extension so I'm afraid I still don't understand. Do you mean VK_EXT_debug_utils the debug extension? That shouldn't have any relation to this.

When you launch your program from RenderDoc you'll run under RenderDoc's environment. It behaves as-if it were a driver with different capabilities so you don't need any special case code you can just run your normal logic to handle different drivers.

from renderdoc.

alecazam avatar alecazam commented on June 26, 2024

This is what I have to do to disable renderDoc, but I'd like to leave the support enabled in our debug builds. But since it modifies the extension list, that's not good. So right now, I have to comment out the second line to test with RenderDoc. On some platforms, I'm detecting the renderdoc dll but that doesn't work on all.

       bool hasRenderDocExtension =  m_debugLayers.IsAvailable( "VK_LAYER_RENDERDOC_Capture" );

	// Since this disables many NV extensions (checkpoints and linear_color_attachment), then leave
	// this off unless this is manually ocmmented out.  Need a way to detect app is being run
	// from RenderDoc.  
	hasRenderDocExtension = false;

from renderdoc.

baldurk avatar baldurk commented on June 26, 2024

Layers are not the same things as extensions but you seem to be using the terms interchangeably. You never have to interact with the RenderDoc layer, and indeed you never should interact with the RenderDoc layer. If you are enabling it by hand then that is definitely wrong and there is nowhere in any documentation or instructions that tells you to do that.

I'm still not entirely sure what you're doing, but as I said above you do not need to make any modifications to your program to 'disable' RenderDoc. Run your program from RenderDoc when you want to use it and allow RenderDoc to work as normal, if you try to interfere with how it works then you may create problems for yourself as it sounds like you are doing or get unwanted behaviour.

from renderdoc.

alecazam avatar alecazam commented on June 26, 2024

Thanks, we build up a list of the debug layers, then query them for extensions. I can try just not adding in that into our array of debug layers, and see if that helps.

from renderdoc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.