Query params output about urlcat

[harshilparmar]

As a first step, we need to reproduce the bug on both 2.x and the master branch - let's see which version it affects. Can you help with this first? After that, let's discuss the results here and decide how to proceed.

@balazsbotond Yeah sure, I will let you know!!

[balazsbotond]

@harshilparmar thank you! I'm sorry it took this long to reply. If you still have the time, I'd be very thankful if you could work on a fix.

[harshilparmar]

@balazsbotond I am on it 👨‍💻

[harshilparmar]

Closing because I decided to delete the 2.x branch and concentrate on maintaining the currently published version.

Really happy to see you back here ☺️

[balazsbotond]

@harshilparmar nice to see you again too :)

[harshilparmar]

Hey @balazsbotond Can I help for this?

[balazsbotond]

@Saafine thank you for the bug report.

I've successfully reproduced it using the currently published npm version and it is indeed a problem.

[balazsbotond]

@harshilparmar thanks, that would be great. I have a lot of work to do these days so I'm glad you showed up.

As a first step, we need to reproduce the bug on both 2.x and the master branch - let's see which version it affects. Can you help with this first? After that, let's discuss the results here and decide how to proceed.

[harshilparmar]

@balazsbotond brother, this issue affects in both 2.x and master.
Observation : I think urlcat second param takes empty string in consideration.

[balazsbotond]

@harshilparmar if you have time, could you backport the fix to the 2.x branch and send another PR against that branch? This way I could release a new patch release after merging it and the latest published version would be free of known bugs.

[harshilparmar]

@harshilparmar if you have time, could you backport the fix to the 2.x branch and send another PR against that branch? This way I could release a new patch release after merging it and the latest published version would be free of known bugs.

Sure brother 👍🏼

[harshilparmar]

@balazsbotond Can you please close this issue? It might take time for new contributors.

[balazsbotond]

Closing because I decided to delete the 2.x branch and concentrate on maintaining the currently published version.