Coder Social home page Coder Social logo

Comments (10)

amio avatar amio commented on July 17, 2024 2
  • Default icon
    Better let user to choose if they want icon within. We could provide icon examples in the index page, hinting user to use it freely.

  • Status consistency
    Nice to have, we need to count all possible status from all 3 CI(and more will comming), to know for sure if this consistency works flawlessly.

  • Non-white icon
    I'm planning modify every non-white icon to white :D We don't provide 'social-style' badge, no need for those non-white icons.

  • Text padding
    Sharp eyes! 👍 Need more tweaks on badgen 😋

from badgen.net.

tunnckoCore avatar tunnckoCore commented on July 17, 2024 1

btw, did you noticed that there is a bit more right padding than left padding in the label side,when there is icon? or it is only on phone, hm.

from badgen.net.

tunnckoCore avatar tunnckoCore commented on July 17, 2024 1

It's convention to be build | passing, but but also it's a good thing to be able to differentiate without hovering the badge to see what is the actual link behind it and which is the CI. That's why i'm for icons by default for the CIs.

from badgen.net.

amio avatar amio commented on July 17, 2024 1

I prefer to leave status text to provider's choice, that would be best suit their definition of status. A CI could do more than just building, the 'passing' may not suit for future use cases, even it looks OK for circleci + travis + appveyor for now.

from badgen.net.

tunnckoCore avatar tunnckoCore commented on July 17, 2024

Sharp eyes! +1 Need more tweaks on badgen yum

It's only on mobile. Android v7 i believe, not sure.

Non-white icon

Absolute. 👍

Status consistency

I didn't get that. What you mean?

we need to count all possible status from all 3 CI

no such need, we just rename the strings and that's it, no changes to detection or any other bussiness logic.

from badgen.net.

tunnckoCore avatar tunnckoCore commented on July 17, 2024

Oooh, i got what you meant with 2nd bullet. Right.

from badgen.net.

amio avatar amio commented on July 17, 2024

it's a good thing to be able to differentiate without hovering the badge to see what is the actual link behind it and which is the CI.

Totally agree! We could change label to CI name, keep their status as it is right now.

from badgen.net.

tunnckoCore avatar tunnckoCore commented on July 17, 2024

CircleCI

// :retried, :canceled, :infrastructure_fail, :timedout,
// :not_run, :running, :failed, :queued, :scheduled,
// :not_running, :no_tests, :fixed, :success
"status" : "success", 

TravisCI - damn, this guys are really bad in APIs and any other case ;d

Seems like they are few passed, failed, errored in build.state
https://docs.travis-ci.com/api/?http#builds
If there is no such repo or account, builds is empty array, so we can set unknown.

keep their status as it is right now.

Naah. Where goes the consistency ;d

AppVeyorCI

  • failed, success, not sure for more, but there should be such as errored

from badgen.net.

tunnckoCore avatar tunnckoCore commented on July 17, 2024

keep their status as it is right now.

Or at least, if build is okey, show passing for all, otherwise their respective term for error/fail/unknown/running/quequed/timeout and etc.

from badgen.net.

amio avatar amio commented on July 17, 2024

BTW, the icon color issue has been fixed in 55970a8#diff-3c6d535456832f7a3a673a4265007624R18

from badgen.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.