Coder Social home page Coder Social logo

Comments (9)

babluboy avatar babluboy commented on May 20, 2024

Thanks for the suggestions, there are four issues you have listed:

  • 1. Content View button should only be visible in the reading mode - This is sensible (and easy to achieve as well), I will be able to push it out quickly
  • 2. The Navigate to Library button should be like an arrow - I have seen this in the Settings, will try and use that instead of the four square button I'm using
  • 3. Having a side bar to show table of contents instead of a contents page so that the user can flip back easily to the page being read if he decides not to jump to a different page. And if the user does decide to jump to another page then the content side bar should dissapear - Again a sensible design, but one that will take some considerable code to achieve. Will try to get this done soon.
  • 4. Showing the correct image of the book cover - This is something I had in mind as well. At the moment unless the ebook specifies a size for the image the image fills the whole content area and appears stretched. Will try to see if I can handle this situation by over riding this behavior. For some ebooks I have which specify size the image comes nicely as shown below.

screenshot from 2017-02-25 14 00 51

from bookworm.

choyan avatar choyan commented on May 20, 2024

Exactly. I will keep informing if anything comes on my mind :)
Thank you very much.

from bookworm.

babluboy avatar babluboy commented on May 20, 2024

@choyan
(1) Content View button should only be visible in the reading mode - completed this and pushed the code to both PPA and Git. Do you get Bookworm from the PPA ?(should be the quickest way to get the updates I make)

from bookworm.

babluboy avatar babluboy commented on May 20, 2024

@choyan I have made a fix for the URL of images, so hopefully some of the ePubs which had relative links and come up with broken/missing images will now work properly. Will be good to know when you test

from bookworm.

babluboy avatar babluboy commented on May 20, 2024

@choyan Last update for today - Implemented the Back Arrow Library button and also hid the Library button in the library view. The Library button is only required in the Reading view but has no use in the Library view. Let me know if you feel the behavior is fine and the code works as expected.
bookwormreadingview

from bookworm.

choyan avatar choyan commented on May 20, 2024

The AppID has created some kind of problem regarding the execution of new version. I've posted the bug on the corresponding bug post.
After the fix, i'll be able to check the other issues :) The AppID has created some kind of problem regarding the execution of new version. I've posted the bug on the corresponding bug post.
After the fix, i'll be able to check the other issues :)

from bookworm.

babluboy avatar babluboy commented on May 20, 2024

@choyan Many thanks for checking this out - must have been a bit sleepy when i pushed out yesterday's changes and did not make the org id changes correctly :-) I was able to replicate the same with my VM and now I have fixed the org id and pushed the code to both the PPA and Git. Hopefully you should be able to do some testing now. Here are the changes I did yesterday:
1- Updated Org Id
2- Updated the Back Button to go back to Library view from the Reading View
3- Removed the Back Button on Library view (the button is only present on the reading view)
4- Made some fixes to display images for some types of ePubs

Note: In case of the app crashing, you can test from the command line with "bookworm --debug". That will print all the debug commands I have put in the code at various places and will tell me where the code is failing. The terminal output you provided in the email helped me pin point the issue with the org id

from bookworm.

choyan avatar choyan commented on May 20, 2024

Great! It's working again now. I built the files from source again. PPA is a bit late here always :)
All issues you've solved are working great now. 👍

from bookworm.

babluboy avatar babluboy commented on May 20, 2024

I have moved (3) and (4) to separate Issues to manage it more easily - see #18 and #19.
Closing this as the first two are resolved

from bookworm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.