Coder Social home page Coder Social logo

Comments (4)

MrMicky-FR avatar MrMicky-FR commented on June 9, 2024

The Request::setTrustedProxies will rewrite IP when the request is from a Cloudflare server (see Symfony documentation):

Request::setTrustedProxies($this->proxies, Request::HEADER_X_FORWARDED_ALL);

What’s the output of $request->ip() ? A Cloudflare IP ?

from plugin-cloudflaresupport.

magrigry avatar magrigry commented on June 9, 2024

The result of $request->ip() is the IP of the docker container 172.23.0.1 (I am running Azuriom with the official docker-compose)
But If I add
image
Now I am getting the correct one

While writting this, I just realized that it might be due to the fact that I am using an other proxy between Cloudflare and the Docker Container. Docker maybe also proxies something ? I don't know...

Anyway the source IP is not replaced by CF-Connecting-IP because the source IP is not trusted
My solution works because it just bypass the trusted proxies which is not very good

from plugin-cloudflaresupport.

MrMicky-FR avatar MrMicky-FR commented on June 9, 2024

Yes, the ideal solution would be to configure Docker to forward the request ip.
Otherwise it’s also possible to replace Request::setTrustedProxies($this->proxies, Request::HEADER_X_FORWARDED_ALL); by Request::setTrustedProxies(['REMOTE_ADDR'], Request::HEADER_X_FORWARDED_ALL); which is nicer than changing the REMOTE_ADDR but this will rewrite the IP even if the request doesn’t come from Cloudflare which can lead to IP spoofing

from plugin-cloudflaresupport.

magrigry avatar magrigry commented on June 9, 2024

Yup, I just disallowed everything but Cloudflare IPs in my nginx config to avoid spoofing. I think I will stick with this dirty fix.
Anyway thanks a lot for your help

from plugin-cloudflaresupport.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.