Coder Social home page Coder Social logo

Comments (5)

omercs avatar omercs commented on June 16, 2024

We added userinfo to rootscope to reduce amount of coding required for developers. We want developers to start with minimum changes.

from azure-activedirectory-library-for-js.

ThorstenHans avatar ThorstenHans commented on June 16, 2024

yes, but having some data being populated within the rootscope from a dependent library isn't a good thing. I don't like the fact that a Service is manipulating my rootscope..

from azure-activedirectory-library-for-js.

RobARichardson avatar RobARichardson commented on June 16, 2024

+1

from azure-activedirectory-library-for-js.

tedvanderveen avatar tedvanderveen commented on June 16, 2024

+1

from azure-activedirectory-library-for-js.

tushargupta51 avatar tushargupta51 commented on June 16, 2024

Setting things on rootScope is similar to setting things to window object. We added userInfo to rootScope to make it easier for developers to access the logged in user. I agree that it is not the best practice to modify things globally or on global scope. Closing this issue as unfortunately we cannot change this now, as this will be a breaking change. We will consider the feedback for our next generation of adal library (we are actively working on that right now).

from azure-activedirectory-library-for-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.