Comments (9)
My concern is that anyone new to this is automatically going to go for the newest version, but that just doesn't work - the bug is repeatable and consistantly failing.
from webapps-deploy.
Seems the yml file didn't attach, renamed it to txt and attached it here
from webapps-deploy.
I had this exact same problem @lassevk
As a quick fix, if you revert to the V2 action, the deployment works successfully
This is the deploy step from our action
# Deploy to UAT
- name: Deploy to Azure WebApp
uses: azure/webapps-deploy@v2
with:
app-name: ${{ env.AZURE_WEBAPP_NAME }}
slot-name: 'prelive'
publish-profile: ${{ secrets.AZURE_UAT_XXXXXX_PROFILE }}
package: ${{ github.workspace }}\publish.zip
from webapps-deploy.
We noticed the problem (and it may be an umbraco specific one, or may be one more related to locked files on our side (particularly log files and nucache files)
from webapps-deploy.
We noticed the problem (and it may be an umbraco specific one, or may be one more related to locked files on our side (particularly log files and nucache files)
The locked file is likely an Umbraco specific problem, or at least related to Umbraco, but the overall issue of a failed deployment being shown as successful is troublesome. If we can't trust the deployment action to actually tell us that there is an issue, we're forced to monitoring it every deployment. We'd rather just have to go look at it if it fails.
from webapps-deploy.
I had this exact same problem @lassevk
As a quick fix, if you revert to the V2 action, the deployment works successfully
This is the deploy step from our action
# Deploy to UAT - name: Deploy to Azure WebApp uses: azure/webapps-deploy@v2 with: app-name: ${{ env.AZURE_WEBAPP_NAME }} slot-name: 'prelive' publish-profile: ${{ secrets.AZURE_UAT_XXXXXX_PROFILE }} package: ${{ github.workspace }}\publish.zip
I believe we upgraded because we were getting warnings about v2 being deprecated, I will need to confer with my colleague tomorrow if it was this action that we upgraded due to warnings or something else. Maybe I'm mixing actions here.
from webapps-deploy.
the overall issue of a failed deployment being shown as successful is troublesome
This is the same behaviour we were seeing - the action was reporting as successfully deploying, but the logs showed that it had failed because a locked file. Agreed that this is incorrect behaviour
from webapps-deploy.
I believe we upgraded because we were getting warnings about v2 being deprecated
I'd be curious about that - I've not seen or been able to find any detail - perhaps a mod or admin can help?
I also see that v3.0 back in October was released but nothing has been updated since : https://github.com/Azure/webapps-deploy/releases
from webapps-deploy.
+1 on this. Extremely frustrating trying to figure out why the action reports success, but my changes aren't being applied. It appeared to be the same issue as lassevk, it was trying to modify a log file but couldn't.
I can confirm using v2 did solve the issue for me. It looks to me that v2 doesn't attempt to access or delete the log files
from webapps-deploy.
Related Issues (20)
- README doesn't have a v3 example or explanation of the differences HOT 4
- Add sample(s) for OIDC HOT 1
- Azure Web App deployment from .zip fails after successfully deploying the content HOT 2
- V3 using node.js 16 upgrade to node.js 20 seeing 16 is deprecated HOT 16
- Deploy to web app does not working for .NET 8 and Linux based deployment - azure/webapps-deploy@v3 HOT 4
- Microsoft Azure Build and deploy PHP app to Azure Web App: Laravel App - Unable to create lockable file HOT 2
- Deployment Faile***, Error: Resource azwb********-tot doesn't exist. HOT 5
- The new option Clean should have defaulted to false or been highlighted as a breaking change HOT 4
- Can't deploy to ACA-based Function App
- Cann't show submit messages, ONLY show OneDeploy
- Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.'
- nodes
- util_1.promisify is not a function HOT 4
- Long deployment urls are cut off for slots HOT 1
- update
- Deploying Web Apps with Sidecar Containers HOT 2
- Central Directory corrupt error when deploying zip with WEBSITE_RUN_FROM_PACKAGE = 1 on linux
- Please upgrade the SQlite version on the default Python images
- Temp files to delete
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webapps-deploy.