waagent not closing connection to terminal when daemonizing about walinuxagent

[yuezh]

@rjschwei What's the version of SUSE and waagent?

[rjschwei]

2.0.11

Any distribution, SLES 11 SP3, or SLES 12

[yuezh]

@rjschwei I didn't meet the issue you descripted on SLES 11 SP3. Here are my steps:
service waagent start
exit
The ssh session ended normally.

[bear454]

@yuezh You can reproduce by stopping any running waagent on a machine, and running

waagent -daemon

[SuperScottz]

@yuezh Could you please have a try to see if it could be reproduced?

[szarkos]

The agent doesn't actually "daemonize" at all, in that it doesn't do the typical double-fork thing and detach from the console when it enters the Agent.Run() loop. That's why the agent still runs in the foreground when you run "waagent -daemon," and why the '&' is required in the init scripts.

The trouble is that even running the agent in the background using the '&' does properly detach the agent from the terminal. So for example, trying to start the agent remotely causes a hang:

ssh [email protected] 'sudo /usr/sbin/waagent -daemon &'
....

[yuezh]

We will implement real "daemonize" in version 2.1

[ahmetb]

@yuezh does 2.1 fix this issue? If so, please close.

[hglkrijger]

closing, due to lack of activity. if this is still a feature request, please reopen.

[rjschwei]

I tested 2.1 with SLES 11 SP4 where this is aproblem as SysV init handles file descriptors differently than systemd (SLES 12 and later) and observed the same problematic behavior.