Coder Social home page Coder Social logo

Comments (8)

maxisam avatar maxisam commented on May 20, 2024 1

@koushdey so what about the problem of having an option to ignore error from certificate auto signed?

I thought the whole issue is about that. Am I the only one feel this way? lol

Yes, there was a bug but IMO that was not the point of the issue.

from k8s-deploy.

shigupt202 avatar shigupt202 commented on May 20, 2024

@jbaojunior We are not supporting arguments currently for any of the actions in K8s-deploy.
@DS-MS Is there any reason why we didn't support arguments here, and in the task either (arguments are allowed only for delete action in KubernetesManifest task)?

from k8s-deploy.

thesattiraju avatar thesattiraju commented on May 20, 2024

In case of deploy we run multiple kubectl commands, like apply, annotate, rollout, delete mapping those args to a single command was tricky. So I suppose we removed args support altogether. We should get rid of the input though, I don't think it's being used anywhere or evaluate using args against our apply commands

from k8s-deploy.

shigupt202 avatar shigupt202 commented on May 20, 2024

That's right. The input is not being used anywhere in this action.

from k8s-deploy.

koushdey avatar koushdey commented on May 20, 2024

Closing it against the PR #139

from k8s-deploy.

maxisam avatar maxisam commented on May 20, 2024

@koushdey Why this issue is closed? The PR doesn't fix the problem.

from k8s-deploy.

koushdey avatar koushdey commented on May 20, 2024

@maxisam The PR is removing the support for the broken functionality of optional input param which gave rise to this issue. The input param was present but was not consumed during runs.

from k8s-deploy.

Lippur avatar Lippur commented on May 20, 2024

I agree that this should be reopened. Right now, it is not possible to deploy to clusters which use a self-signed certificate. The issue here was not that it seemed possible to pass arguments, it's that it isn't possible to pass arguments.

from k8s-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.