Comments (11)
@v-Ajnava, could you take a look at this issue or provide us with correct point of contact?
from azure-sdk-for-js.
Thank you for opening this issue! We are routing it to the appropriate team for follow up.
from azure-sdk-for-js.
This is when using the azure-sb
library, therefore moving it to the right repo
from azure-sdk-for-js.
@amarzavery This looks like the issue with how expiry dates are dealt with inside of azure-common.
If we expect the same to happen in the new service bus library, then moving it to the new repo makes sense, else this is a bug fix needed in azure-common. Am I missing something?
from azure-sdk-for-js.
I feel this seems to be a service side issue and not an issue with the client. If this is a client side issue then I would recommend to ensure that this doesn't happen in the new library that is developed for http based atom apis
from azure-sdk-for-js.
Fair point, will transfer back and loop in the service team. Thanks!
from azure-sdk-for-js.
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jfggdl
from azure-sdk-for-js.
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jfggdl
from azure-sdk-for-js.
@nemakam, would you please confirm that this is a service-side issue. If so, would you please update the milestone date?
from azure-sdk-for-js.
@ramya-rao-a @amarzavery , this should be a client side bug. Service code never deals with localized time and only deals with UTC. In this particular case, service takes in a token (cbs link) which has the timeout mentioned, in UTC, and returns the token validity value, again in UTC. The client should take care of localizing it and make sure than changes in daylight savings doesn't affect the way token renewal happens within the client
from azure-sdk-for-js.
When looking at how azure-sb handles the expiration date for credentials, the only thing that stuck out was it was using the minutesFromNow
helper method in azure-common
:
https://github.com/Azure/azure-sdk-for-node/blob/6faf0dce4bb2a7d65592047852cb5abeb5282bbc/lib/common/lib/util/date.js#L53-L56
This method probably could be using setUTCMinutes
and getUTCMinutes
instead of setMinutes
and getMinutes
, but I don't think this would actually cause an issue unless DST caused the clock change by a fraction of an hour.
I also found similar logic around how we were caching the accessToken for the credential. There we were using getMilliseconds
and setMilliseconds
instead of the UTC variants. It still seems unlikely though that this would cause the issue noted above (I could see getHour
causing an issue, but that isn't being called in any code paths).
That said, I did check that in core-amqp/amqp-common we're setting the expiration on the UTC value given from the date object, so should not have this issue in @azure/service-bus
which replaces azure-sb
. I also confirmed that core-http/core-auth are working with UTC times directly. I'm closing this issue for now, though we can reopen if it comes up in @azure/service-bus
.
from azure-sdk-for-js.
Related Issues (20)
- [core] core-client-rest `PathUnchecked` does not infer path parameters which are not preceded by `/`
- read ECONNRESET when trying to stream GPT response with a PTU deployment HOT 4
- `@azure/monitor-opentelemetry` ignoes AZURE_LOG_LEVEL setting when `APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL` is not set
- TS2305: Module '"@azure/openai"' has no exported member 'AzureKeyCredential'. HOT 4
- ResourceNotFound error when connecting to Azure OpenAI using latest JavaScript SDK (version 2.0.0-beta.1) HOT 3
- [Core] add ResourceId support
- Ali963.sy
- Refresh all the rlc sdks in sdk repo HOT 5
- can not validate the authority HOT 2
- How to use aggregation with @azure/cosmos in nosql database HOT 2
- Unable to resolve module crypto - @azure/notification-hubs HOT 1
- [feature request] adding `generateSasStringToSign` for other packages
- [Service Bus] PartitionedSubscriptionWithSessions: deleteMessages (session) failing in nightly runs HOT 2
- [Storage - File Datalake] macoslatest_224x_node failing in nightly runs
- Dependency package puppeteer has a new version available HOT 1
- Dependency of @azure/core-xml has vulnerability CVE-2024-41818 HOT 3
- Regenerate Azure AI Search with latest Swagger
- [core] Copy changes for refresh_on support to ts-http-runtime
- unable to specify stream_options for completions method HOT 1
- ability to specifiy search_type and embedding endpoint in the v4 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-sdk-for-js.