High timeout for Commerce UsageAggregates list (on 504 gateway error) about azure-sdk-for-js

[amarzavery]

We have an internal exponential retry mechanism for certain amount of time and then bail out if things still fail.

• ExponentialRetryFilter
• SystemErrorRetryFilter

[ramya-rao-a]

@RodgeFu, @nickzhums, @qiaozha Can we close this issue with a pointer to show how to configure the retry policy?

[nickzhums]

@RodgeFu @zikalino do we have any track 1 retry policy samples?

[changlong-liu]

Hi @itilitymaarten ,

You can find exponentialRetryPolicy, systemErrorRetryPolicy and throttlingRetryPolicy here: https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/core/core-http/src/policies

They can be used as any other policies in JS SDK, a sample for policy assignment can be found here:

azure-sdk-for-js/sdk/core/core-http/samples/node-sample.ts

Line 42 in 7b0e5da

const clientOptions: coreHttp.ServiceClientOptions = {

[ramya-rao-a]

@changlong-liu That sample is for @azure/core-http where as the management libraries use @azure/ms-rest-js. Though the former is built on top of the latter, it might have had changes done to it. Have you tried that sample with @azure/arm-commerce package?

[changlong-liu]

Thank you @ramya-rao-a .
I have just had a try on @azure/arm-commerce, and found it's not using core-http, but the old @azure/ms-rest-js 1.x.x. And also an old version for ms-rest-nodeauth.
Correct the policy folder for ms-rest-js as: https://github.com/Azure/ms-rest-js/tree/1.x/lib/policies
Reference code for creating policy factory: https://github.com/Azure/ms-rest-js/blob/master/lib/serviceClient.ts#L401

Below are some details in my verification for @azure/[email protected]:
npm install "@azure/[email protected]"
npm install "@azure/ms-rest-nodeauth": "^2.0.4"

code:

import { UsageManagementClient, UsageManagementModels } from "@azure/arm-commerce"
import { exponentialRetryPolicy, signingPolicy, generateClientRequestIdPolicy, deserializationPolicy, redirectPolicy} from "@azure/ms-rest-js"
import { loginWithServicePrincipalSecret, ApplicationTokenCredentials } from "@azure/ms-rest-nodeauth";


function main() {
  loginWithServicePrincipalSecret(
    "[YOUR CLIENT ID]",
    "[YOUR SECRET]",
    "[YOUR TENANT]",
    (err: any, credentials: ApplicationTokenCredentials) => {
      if (err) throw err;

      const clientOptions: UsageManagementModels.UsageManagementClientOptions = {
        requestPolicyFactories: [
          generateClientRequestIdPolicy(),
          signingPolicy(credentials),
          redirectPolicy(),
          exponentialRetryPolicy(10, 10),
          deserializationPolicy()
        ]
      };

      const client = new UsageManagementClient(credentials, subscriptionId, clientOptions);
      const reportedStartTime = new Date("2019-3-1 0:00:00Z").toISOString();
      const reportedEndTime = new Date("2019-4-1 0:00:00Z").toISOString();
      client.usageAggregates.list(reportedStartTime, reportedEndTime).then((result) => {
        console.log("The result is:");
        console.log(result);
      });

    }
  );
}

main();