Coder Social home page Coder Social logo

Comments (13)

derisen avatar derisen commented on August 23, 2024 2

@jeromechrist looks like the app is never receiving an access token from B2C, which causes the loop as acquireTokenRedirect keeps trying. For a start, can you double check if you have granted admin consent to permissions on Azure AD B2C portal (SPA app registration)? I've just realized this step is missing in registration steps -apologies for that.

from ms-identity-javascript-angular-tutorial.

derisen avatar derisen commented on August 23, 2024 1

@jeromechrist thank you very much for the details and the repro link, I was able to reproduce the issue. I'll get back to you as soon as I figure this out.

from ms-identity-javascript-angular-tutorial.

jeromechrist avatar jeromechrist commented on August 23, 2024 1

image

I just clicked that grant permission button and I can access the APIs feature fine.

But there is still a loop when I click on "Edit Profile"

Screen.Recording.2021-06-02.at.00.04.35.mov

from ms-identity-javascript-angular-tutorial.

jeromechrist avatar jeromechrist commented on August 23, 2024 1

hey @derisen, sorry for the delay, just for the heck of it I tried another browser and it looks like this bug is happening on Safari only, no issues on Edge (dev channel)

on Safari the bug repro is 100%

Screen.Recording.2021-06-03.at.21.13.49.mov

Safari

  • Version 14.1.1 (16611.2.7.1.4)
  • I have an adblocker (ADGUARD) but I turned it off specifically for this test

Edge

  • Version 92.0.902.2 (Official build) Dev(x86_64)
  • I have an adblocker (uBlock Origin), didn't turned it off

Mac OS

  • 11.4 (20F71)

from ms-identity-javascript-angular-tutorial.

jeromechrist avatar jeromechrist commented on August 23, 2024 1

Yep, created there AzureAD/microsoft-authentication-library-for-js#3713

from ms-identity-javascript-angular-tutorial.

derisen avatar derisen commented on August 23, 2024

@jeromechrist strange, I can reproduce this with the edit user-flow you've set up, but not with my edit user-flow. I'm suspecting this is to do with your configuration. Have you configured any user attributes and/or application claims? It might be that there is no attribute/claim to edit, which might cause the edit screen not show up at all.

ss

from ms-identity-javascript-angular-tutorial.

jeromechrist avatar jeromechrist commented on August 23, 2024

@derisen yep that was the case, I did selected claims in "Application claims" but no in "User attributes". After setting a few it works !
Screenshot 2021-06-02 at 15 13 16
Screenshot 2021-06-02 at 15 13 36

Thank you for helping troubleshoot the issue

from ms-identity-javascript-angular-tutorial.

derisen avatar derisen commented on August 23, 2024

@jeromechrist awesome! I'll update the sample README with the missing admin consent step and add some remarks about setting up user claims. Really appreciate all the details you provided in the issue -makes our lives easier : )

from ms-identity-javascript-angular-tutorial.

jeromechrist avatar jeromechrist commented on August 23, 2024

@derisen heyyyyy sorry, it did resolve the edit profile part but the loop is back on the API 😕

Screen.Recording.2021-06-02.at.16.07.42.mov

from ms-identity-javascript-angular-tutorial.

derisen avatar derisen commented on August 23, 2024

@jeromechrist hmm, I'll check this with B2C team and get back to you. In the meantime, can you send me a network trace using Fiddler? My email is on my GitHub profile.

from ms-identity-javascript-angular-tutorial.

derisen avatar derisen commented on August 23, 2024

@jeromechrist Ok, I've just tested this on a Mac with Safari and I can reproduce it as well.

At this point, it would be best to raise this issue in the main MSAL.js repo, as this is likely to do with the msal-angular itself rather than the sample. I can't seem to transfer it, can you please create a bug report there?

from ms-identity-javascript-angular-tutorial.

github-actions avatar github-actions commented on August 23, 2024

This issue has not seen activity in 14 days. If your issue has not been resolved please leave a comment to keep this open. It will be closed in 7 days if it remains stale.

from ms-identity-javascript-angular-tutorial.

github-actions avatar github-actions commented on August 23, 2024

This issue has been closed due to inactivity. If this has not been resolved please open a new issue. Thanks!

from ms-identity-javascript-angular-tutorial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.