Attachments are not properly cleared and added to subsequent emails about abc-silverstripe-mailer

[axyr]

And a test method :

public function testAttachmentsGetClearedForSubsequentEmails()
    {
        // phpunit is a bit broken so we manually call the dependent tests;
        $this->testSMTPEmail();

        // create file
        $fileContents = 'test content';
        $fileName = 'test.txt';
        $type = 'text/plain';

        // create email
        $e = new SMTPEmail();
        $e->To = '[email protected]';
        $e->Subject = "Hi there";
        $e->Body = "I just really wanted to email you and say hi.";
        $e->attachFileFromString($fileContents, $fileName, $type);

        // get the mailer bound to the Email class
        $e->setupMailer();
        $mailer = SMTPEmail::mailer()->mailer;

        // check attached files
        $files = $mailer->getAttachments();
        $this->assertEquals(true, $files[0][0] == $fileContents);
        $this->assertEquals(true, $files[0][1] == $fileName);
        $this->assertEquals(true, $files[0][4] == $type);

        // check send
        $this->assertEquals(true, $e->send());

        // send second email
        $fileContents = 'test content 2';
        $fileName = 'test2.txt';
        $type = 'text/plain';
        $e = new SMTPEmail();
        $e->To = '[email protected]';
        $e->Subject = "Hi there";
        $e->Body = "I just really wanted to email you and say hi.";
        $e->attachFileFromString($fileContents, $fileName, $type);

        $files = $mailer->getAttachments();
        $this->assertEquals(1, count($files));

    }

[azt3k]

Thanks for reporting this, I'll have a look.