Coder Social home page Coder Social logo

Comments (5)

axunonb avatar axunonb commented on May 20, 2024

Did you mean to make the Indentify_Windows_Platform test conditional - fails on linux.

Actually the test should work also without ExcludePlatform. The intention is to in include the new Platform class in unit tests.

from mailmergelib.

axunonb avatar axunonb commented on May 20, 2024

@thegruffalo Could you elaborate what exactly fails with the test, please?

from mailmergelib.

thegruffalo avatar thegruffalo commented on May 20, 2024

Here is the test output:

---- Test Execution Summary -----

MailMergeLib.Tests.Platform.Indentify_Windows_Platform:
Outcome: Failed
Error Message:
MailMergeLib.UnsupportedPlatformException : Unknown
Stack Trace:
at MailMergeLib.Platform.DeterminePlatform() in /home/thill/tdev/MMLO/MailMergeLib/MailMergeLib/Platform.cs:line 65
at MailMergeLib.Tests.Platform.Indentify_Windows_Platform() in /home/thill/tdev/MMLO/MailMergeLib/MailMergeLib.Tests/Platform.cs:line 24

Total tests: 1. Passed: 0. Failed: 1. Skipped: 0

As an alternative, maybe, something like this would be easier to implement https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.runtimeinformation.isosplatform?view=netcore-2.2

from mailmergelib.

axunonb avatar axunonb commented on May 20, 2024

With commit 1b08f36 we're using System.Runtime.InteropServices.OSPlatform to detect the platform. Does the test pass now on Linux?

from mailmergelib.

axunonb avatar axunonb commented on May 20, 2024

Tests for commit 1b08f36 complete successfully on Ubuntu 18.04 LTS and Windows.

from mailmergelib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.