Comments (10)
Hi @vezdeneszter ,
Can I work in this ? I have experience with python, but this would be the first time I would be contributing to an actual python package hosted on PIP.
Best Regards.
Kabiir Krishna
from dem.
Hi, thank you for your offer to contribute! Sure, I'll assign it to you. Please don't forget to join our Discord server: https://discord.com/invite/Nv6hSzXruK where we have a dedicated channel for Hacktoberfest. There you can discuss this issue in detail 😊
from dem.
Thanks !
appreciate it 👍
from dem.
Hi Guys,
I was able to get the project up and running. But I am unable to re-build the project from source (is it required ?) to see whatever changes I have made to my local branch. I was also facing some issues in creating a test environment to check my outputs.
Changes made till now:
I simply added a new cmd_script
and some basic code in main.py
to run it like other CLI commands. However, when I input dem list-host
I get the following error:
Let me know if there are any other steps to be performed apart from the ones mentioned in the DEM Contribution Guidelines
Best Regards.
Kabiir Krishna
P.S.
Here is my System info (if it help)
from dem.
Hi @Kabiirk
Your approach to the implementation looks good to me.
You installed DEM as a pip package, meaning you don't run it from source. This is the reason why you can't use your new command. First, you need to set up a virtual environment with poetry and you will be able to test you modifications. If you need any help to do that, text me on Discord!
The first error you see means that something is not quite alright in your installation. (The error message you see is not very helpful, so that must be improved in the future.) Could you tell me which Docker Engine version do you have?
from dem.
Hi @janosmurai ,
Appreciate the prompt revert.
-
Is this the correct way to setup virtualenv via poetry (please refer screenshot below) ? I followed what was mentioned in the Working with DEM source section of the guidelines. If required we'll troubleshoot this further on discord.
I also tried running thedem create DEV_ENV_NAME
but was receiving error as shown in my earlier message (1st Screenshot).
from dem.
Yes, my bad, I see it now that you were in the virtual env. You set it up the right way.
It looks like every dependency is correct. Could you please also try the simple comand dem --version
.
from dem.
Hi Janos,
dem --version
works for me. I have messaged you on Discord to take things forward.
from dem.
Hi all,
Done with coding this feature, the outputs are as follows:
Let me know if this works & I can make the PR or what are the changes, if any. (for e.g. dem add-host --help
mentions that host['address']
should be an IP address & not a URL, w.r.t that, Let me know if address of Test4
of Output 2 is fine with you guy, or if that is a 'bug'.)
Best Regards,
Kabiir Krishna
from dem.
The command usage LGTM. If your modification complies with the contribution guide, you can open the PR.
The dem add-host --help
states that the address input parameter is IP or hostname of the host. The way you tested this command is okay.
In the future, a check will be implemented to inform the user that the input IP address or hostname of the dem add-host
command points to a server capable of acting as a remote host.
from dem.
Related Issues (20)
- [DOC] Update Readme HOT 1
- [FeatureRequest] Dev Env init for given workspace
- [FeatureRequest] Modify the existing delete command - delete the Dev Env descriptor from the dev_env.json file HOT 2
- [FeatureRequest] Add host command HOT 3
- [FeatureRequest] Delete host command HOT 2
- [FeatureRequest] Create installer for DEM
- [FeatureRequest] Rename the existing clone command to `cp` HOT 2
- [FeatureRequest] Create a new functionality for the clone command: get the Dev Env descriptor from the catalog
- [FeatureRequest] Create command - add option to set the host for the tool images
- [FeatureRequest] Modify command - add option to modify the host for the tool images HOT 2
- [FeatureRequest] Install command - install a Dev Env from a locally available Dev Env descriptor HOT 4
- [FeatureRequest] Uninstall command - remove all images required by the Dev Env descriptor
- [FeatureRequest] Rewrite the Dev Env Settings Window
- [FeatureRequest] Dev Env Settings Window scrolling
- [FeatureRequest] Dev Env Settings Window input field
- [BUG] During the installation of a Dev Env, the tool image can't be pulled, if the image's registry is not available
- [BUG] DEM loads irrelevant registries/repositories from Docker Hub
- [FeatureRequest] Dev Env Settings Window option to add unkown repository name
- [FeatureRequest] Improve the output of the `list-tools` command
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dem.