Coder Social home page Coder Social logo

Comments (11)

wesk avatar wesk commented on May 28, 2024

Thanks for the report, I'm rebuilding the docs manually now to see if that fixes the search

from syne-tune.

wesk avatar wesk commented on May 28, 2024

Looks like a regression was introduced into the docs that broke search, looking into this. As an immediate mitigation, you can search using this older docs build: https://syne-tune--587.org.readthedocs.build/en/587/

See for example this search result for SchedulerDecision: https://syne-tune--587.org.readthedocs.build/en/587/_apidoc/syne_tune.optimizer.scheduler.html#syne_tune.optimizer.scheduler.SchedulerDecision

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

Hello, SchedulerDecision is what is returned by scheduler.on_trial_result, which is triggered by a reported result being received. The value STOP means the running trial should be stopped.

Now, it could be that the trial has already finished, because it may finish just after returning the last report, because it was in the final epoch. In this case, status == Status.completed, and we don't have to stop it.

So, the line you ask about is reached when the scheduler, as reaction to a reported results, asks to stop the trial, but it has not yet finished on its own. We then ask the backend to stop it.

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

SchedulerDecision is really simple, but Status is a bit more tricky, because there is stopped and stopping. David did this. I tend to ignore stopping, it may not really ever be used. For a SageMaker job, there is stopping, which is the state between active and stopped.

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

@wesk Why would search in the docs be broken?

from syne-tune.

wistuba avatar wistuba commented on May 28, 2024

Are you saying that a Python process will not be killed as soon as it reports for the final epoch? Or are you saying it won't be killed if it is already dead? (local backend)

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

The second, I think. We only observe the Status.completed value when the job really ends. And in that case, we do not have to stop it again. But David wrote this, so I am a bit guessing. But I am pretty sure

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

@wesk This issue is now primarily about the search not working in our docs. It works with old sphinx dependencies. I am checking what happens locally when the dependencies are re-installed

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

OK. I can confirm that:

  • If docs in main are built with "old" virtual env, the search works
  • If docs in main are built after creating a new venv, search fails (just see "Searching ..." forever)

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

I don't find any recent reports of search failing in sphinx. Dropping the ball here

from syne-tune.

mseeger avatar mseeger commented on May 28, 2024

OK, broken search is fixed by #602 (thanks, Martin!), and docs improved in #603

from syne-tune.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.